Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nojnhuh to reviewers list #3076

Merged
merged 1 commit into from
Jan 31, 2023
Merged

add nojnhuh to reviewers list #3076

merged 1 commit into from
Jan 31, 2023

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR will add @nojnhuh as a CAPZ reviewer.

According to the requirements defined here:

Jon played an essential role in graduating CAPZ's AKS solution from experimental. I propose formally acknowledging his current and future efforts by making him a CAPZ reviewer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2023
marosset
marosset approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Welcome @nojnhuh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a193f09d8cb9437bde59e9d4dd8a8c7f8883637

@mboersma
Copy link
Contributor

/lgtm++

@nojnhuh has been a solid contributor and a great reviewer already. Welcome!

@jackfrancis
Copy link
Contributor Author

/retest

e2e flake is being addressed here: #3075

@CecileRobertMichon
Copy link
Contributor

/lgtm++

Very well deserved :)

@CecileRobertMichon
Copy link
Contributor

/cc @devigned @sonasingh46 @jsturtevant @Jont828

OWNERs who haven't LGTMed this yet ^

sonasingh46
sonasingh46 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@sonasingh46 sonasingh46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks @nojnhuh

@devigned
Copy link
Contributor

/lgtm

Yay!! Way to be, @nojnhuh!

@Jont828
Copy link
Contributor

Jont828 commented Jan 24, 2023

/lgtm

Congrats!!!

@CecileRobertMichon
Copy link
Contributor

/hold
/approve

Lazy consensus until end of week (1/30)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@mtougeron
Copy link
Member

+1 @nojnhuh has been great!

@mboersma
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1d28b4b into kubernetes-sigs:main Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonasingh46 sonasingh46 sonasingh46 approved these changes

@marosset marosset marosset approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@devigned devigned Awaiting requested review from devigned

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@devigned devigned

@Jont828 Jont828

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
9 participants
@jackfrancis @k8s-ci-robot @mboersma @CecileRobertMichon @devigned @Jont828 @mtougeron @marosset @sonasingh46