don’t default to AKS networkPolicy=calico

[jackfrancis]

What type of PR is this?

/kind flake
/kind feature

What this PR does / why we need it:

This PR removes an opinionated default for AKS clusters to use the calico NetworkPolicy feature.

I was unaware that this default configuration enforcement existed. It is not documented anywhere I can see, and I'm not aware of any justification to include this opinionated cluster configuration for CAPZ-originating AKS clusters: we should let the user decide whether or not to include the installation of either calico or azure NetworkPolicy, as either requires additional operational overhead and other considerations that aren't suitable for choosing one or the other as a default (IMO).

Feature support for calico and azure NetworkPolicy remain unchanged.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

don’t default to AKS networkPolicy=calico

[jackfrancis]

@mtougeron @zmalik @dthorsen @primeroz @sonasingh46 @LochanRn @zioproto @austintackaberry @karthikbalasub @michalno1 @meixingdb Does anyone have any concerns about this change? I do have a medium-strong opinion that we CAPZ should not opinionate about calico for NetworkPolicy, but there is the fact that this is a behavioral change and user expectation may have acclimated to calico by default.

Please share any downsides to reverting this default, thank you!

[dthorsen]

I agree. I think it makes sense to make this change now while AKS support is still in experimental. We should just ensure that the behavioral change is documented in the release notes.

[mtougeron]

I agree. I think it makes sense to make this change now while AKS support is still in experimental. We should just ensure that the behavioral change is documented in the release notes.

+1 to this

[CecileRobertMichon]

/lgtm

[CecileRobertMichon]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/retest

[jackfrancis]

/retest

[k8s-ci-robot]

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-e2e	058a6e0	link	true	/test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jackfrancis]

/retest