Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add managed addon info #2964

Merged
merged 1 commit into from
Jan 4, 2023
Merged

📖 Add managed addon info #2964

merged 1 commit into from
Jan 4, 2023

Conversation

dtzar
Copy link
Contributor

@dtzar dtzar commented Dec 21, 2022

Signed-off-by: David Tesar [email protected]

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add documentation on how to specify managed cluster addons

Release note:

Add documentation on how to specify managed cluster addons

@dtzar
Add managed addon info
577f5f8 
Signed-off-by: David Tesar <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dtzar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2022
@dtzar dtzar marked this pull request as ready for review December 21, 2022 20:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2022
CecileRobertMichon
CecileRobertMichon reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2022
mboersma
mboersma reviewed Dec 21, 2022
View reviewed changes
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
docs/book/src/topics/addons.md Show resolved Hide resolved
docs/book/src/topics/addons.md Show resolved Hide resolved
CecileRobertMichon
CecileRobertMichon reviewed Dec 22, 2022
View reviewed changes
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
docs/book/src/topics/managedcluster.md Outdated Show resolved Hide resolved
docs/book/src/topics/managedcluster.md Outdated Show resolved Hide resolved
CecileRobertMichon
CecileRobertMichon reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

can you please squash commits?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@dtzar dtzar force-pushed the docs-addonupdate branch from baa12c6 to 577f5f8 Compare January 3, 2023 23:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@dtzar
Copy link
Contributor Author

dtzar commented Jan 3, 2023

Squash complete @CecileRobertMichon

mboersma
mboersma reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@CecileRobertMichon
Copy link
Contributor

/approve

thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2d75f5e into kubernetes-sigs:main Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 4, 2023
@dtzar dtzar deleted the docs-addonupdate branch January 4, 2023 19:58
@dtzar dtzar mentioned this pull request Mar 22, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@zmalik zmalik zmalik left review comments

@mboersma mboersma mboersma left review comments

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

@devigned devigned Awaiting requested review from devigned

Assignees

@mboersma mboersma

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@dtzar @k8s-ci-robot @CecileRobertMichon @mboersma @zmalik