Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize autorest/azure import alias as azureautorest #2958

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Standardize autorest/azure import alias as azureautorest #2958

merged 1 commit into from
Jan 5, 2023

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 19, 2022 •
edited
Loading

What type of PR is this?:

/kind cleanup

What this PR does / why we need it:

Adds this import alias to those enforced by the linter:

import azureautorest "github.com/Azure/go-autorest/autorest/azure"

Which issue(s) this PR fixes:

See this comment for the inspiration.

Special notes for your reviewer:

See also #2974

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2022
@mboersma
Copy link
Contributor Author

/retest

@mboersma mboersma mentioned this pull request Dec 20, 2022
Merged
3 tasks
@mboersma mboersma force-pushed the standard-autorest-import branch from 39c7a93 to f0aaac1 Compare January 4, 2023 21:59
@mboersma mboersma force-pushed the standard-autorest-import branch from f0aaac1 to 8431a3e Compare January 4, 2023 22:01
@mboersma
Copy link
Contributor Author

mboersma commented Jan 4, 2023

/retitle Standardize autorest/azure import alias as azureautorest

@k8s-ci-robot k8s-ci-robot changed the title Standardize autorest/azure import alias as autorestazure Standardize autorest/azure import alias as azureautorest Jan 4, 2023
CecileRobertMichon
CecileRobertMichon reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@CecileRobertMichon
Copy link
Contributor

/retest

@jackfrancis jackfrancis added this to the v1.7 milestone Jan 5, 2023
@jackfrancis
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 555d98d into kubernetes-sigs:main Jan 5, 2023
@mboersma mboersma deleted the standard-autorest-import branch January 5, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@devigned devigned Awaiting requested review from devigned

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @jackfrancis