-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSI proxy and containerd logger to machine pool test templates #2947
Add CSI proxy and containerd logger to machine pool test templates #2947
Conversation
/assign @marosset |
- name: csi-proxy-addon | ||
files: | ||
- csi-proxy=../../../addons/windows/csi-proxy/csi-proxy.yaml | ||
- name: containerd-logger-${CLUSTER_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marosset @jsturtevant I wasn't sure if we want this containerd-logger too, I added it because it was also misssing in the machine pool templates as opposed to the regular prow templates with windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include it.
It isn't necessary for running any of the CI jobs but it does make it much easier to troubleshoot issues.
@CecileRobertMichon @marosset if we needed these configmaps for these test templates how did that yield flaky tests (I would think the tests would be always failing)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
@jackfrancis because of #2933 |
I think we didn't always run the CSI tests for machine pool clusters? |
@CecileRobertMichon @marosset thank you I'll fix #2933 |
@jackfrancis thanks! Should we merge this to address flakes in the meantime? |
@CecileRobertMichon yes! |
can you please lgtm + approve? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it: Fixes a flake in the MachinePool test where CSI drivers fail due to missing CSI proxy.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2922
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: