Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSI proxy and containerd logger to machine pool test templates #2947

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Dec 15, 2022

What type of PR is this?
/kind failing-test

What this PR does / why we need it: Fixes a flake in the MachinePool test where CSI drivers fail due to missing CSI proxy.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2922

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 15, 2022
@CecileRobertMichon
Copy link
Contributor Author

/assign @marosset

- name: csi-proxy-addon
files:
- csi-proxy=../../../addons/windows/csi-proxy/csi-proxy.yaml
- name: containerd-logger-${CLUSTER_NAME}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marosset @jsturtevant I wasn't sure if we want this containerd-logger too, I added it because it was also misssing in the machine pool templates as opposed to the regular prow templates with windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include it.
It isn't necessary for running any of the CI jobs but it does make it much easier to troubleshoot issues.

@jackfrancis
Copy link
Contributor

@CecileRobertMichon @marosset if we needed these configmaps for these test templates how did that yield flaky tests (I would think the tests would be always failing)?

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2022
@CecileRobertMichon
Copy link
Contributor Author

@jackfrancis because of #2933

@marosset
Copy link
Contributor

@CecileRobertMichon @marosset if we needed these configmaps for these test templates how did that yield flaky tests (I would think the tests would be always failing)?

I think we didn't always run the CSI tests for machine pool clusters?
But this is a good question.

@jackfrancis
Copy link
Contributor

@CecileRobertMichon @marosset thank you

I'll fix #2933

@CecileRobertMichon
Copy link
Contributor Author

@jackfrancis thanks! Should we merge this to address flakes in the meantime?

@jackfrancis
Copy link
Contributor

@CecileRobertMichon yes!

@CecileRobertMichon
Copy link
Contributor Author

@CecileRobertMichon yes!

can you please lgtm + approve?

@jackfrancis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit c1b8d85 into kubernetes-sigs:main Dec 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CSI AzureDisk E2E failures
4 participants