Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] Default Ubuntu to 22.04 for new k8s versions #2908

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #2807

/assign jackfrancis

Default Ubuntu to 22.04 for new k8s versions

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval by writing /assign @neolit123 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2022
@CecileRobertMichon
Copy link
Contributor

/hold

@jackfrancis @mboersma why the cherry-pick? This isn't a bug fix AFAICT

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@mboersma
Copy link
Contributor

mboersma commented Dec 6, 2022

This isn't a bug fix AFAICT

I agree overall, we should probably close these cherry-picks.

But...maybe it's better that all releases get the same distros for consistency? Otherwise, jobs based on release-1.6 will use Ubuntu 20.04 while newer jobs will use 22.04.

I'm not sure that's important, it's just the only argument I could think of besides "increased exposure for this code change."

@jackfrancis
Copy link
Contributor

@CecileRobertMichon @mboersma I think I have a naive understanding of how this might work across our supported branches. By convention do we not backport the support of new k8s versions into our release branches?

@CecileRobertMichon
Copy link
Contributor

I think it's okay to cherry-pick it if there is a strong argument to, but we should be extra diligent to add justification when cherry-picking something that is labeled as "kind/feature"

By convention do we not backport the support of new k8s versions into our release branches

This PR is not adding k8s version support, it's changing the default OS version

@mboersma
Copy link
Contributor

mboersma commented Dec 7, 2022

it's changing the default OS version

Agreed, new k8s patches will still be supported on older branches. They'll just default to Ubuntu 20.04 whereas e2e on main and CAPZ's next release might use 22.04 for the same Kubernetes version. I don't think that's a problem on its own.

@jackfrancis
Copy link
Contributor

@mboersma @CecileRobertMichon version support on older branches limited to 20.04 vs 22.04 is definitely (IMO) not a problem, so I'll close these cherry-pick PRs!

@jackfrancis jackfrancis closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants