-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] Default Ubuntu to 22.04 for new k8s versions #2908
[release-1.6] Default Ubuntu to 22.04 for new k8s versions #2908
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold @jackfrancis @mboersma why the cherry-pick? This isn't a bug fix AFAICT |
I agree overall, we should probably close these cherry-picks. But...maybe it's better that all releases get the same distros for consistency? Otherwise, jobs based on release-1.6 will use Ubuntu 20.04 while newer jobs will use 22.04. I'm not sure that's important, it's just the only argument I could think of besides "increased exposure for this code change." |
@CecileRobertMichon @mboersma I think I have a naive understanding of how this might work across our supported branches. By convention do we not backport the support of new k8s versions into our release branches? |
I think it's okay to cherry-pick it if there is a strong argument to, but we should be extra diligent to add justification when cherry-picking something that is labeled as "kind/feature"
This PR is not adding k8s version support, it's changing the default OS version |
Agreed, new k8s patches will still be supported on older branches. They'll just default to Ubuntu 20.04 whereas e2e on |
@mboersma @CecileRobertMichon version support on older branches limited to 20.04 vs 22.04 is definitely (IMO) not a problem, so I'll close these cherry-pick PRs! |
This is an automated cherry-pick of #2807
/assign jackfrancis