Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: always use registry.k8s.io #2824

Merged

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This PR updates the capz templates that are use for running custom kubernetes builds to always use registry.k8s.io in response to a migration to the new registry URL across all supported Kubernetes versions. E.g.:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2022
@jackfrancis
Copy link
Contributor Author

/cherry-pick release-1.5 release-1.6

@k8s-infra-cherrypick-robot

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.5 release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5 release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor Author

cc @neolit123

@neolit123
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2022
@CecileRobertMichon
Copy link
Contributor

Posting kubernetes-sigs/cluster-api#7471 (comment) as additional context that all images starting v1.22+ are already published in registry.k8s.io

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7fd5514 into kubernetes-sigs:main Nov 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Nov 17, 2022
@k8s-infra-cherrypick-robot

@jackfrancis: cannot checkout release-1.5 release-1.6: error checking out release-1.5 release-1.6: exit status 1. output: error: pathspec 'release-1.5 release-1.6' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.5 release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor Author

/cherry-pick release-1.5

@jackfrancis
Copy link
Contributor Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #2827

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #2828

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the capz-ci-registry.k8s.io branch November 17, 2022 21:54
lzhecheng added a commit to lzhecheng/cloud-provider-azure that referenced this pull request Jan 13, 2023
edreed pushed a commit to edreed/cloud-provider-azure that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants