add control plane tolerations to aad pod identity #2816
Conversation
Signed-off-by: Ashutosh Kumar <[email protected]>
k8s-ci-robot
added
release-note
|
/cherry-pick release-1.5 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.6 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't think there is any specific way to test other than writing a test that checks if the capz-nmi pods are running on all the nodes including the control plane nodes. |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@jackfrancis: new pull request created: #2863 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jackfrancis: new pull request created: #2864 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ashutosh Kumar [email protected]
What type of PR is this?
What this PR does / why we need it:
Adds control plane tolerations to aad pod identity. The capz manager pod has already this tolerations. The toleration is needed on aad pod identity as well otherwise for situations when capz pod gets scheduled on control plane node, the authentication to azure cloud will fails as the capz-nmi(aad pod identity) pod is not present on the control plane node due to taint policy.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: