Cleanup remote peerings when resource group is deleted

[willie-yao]

What type of PR is this?
/kind bug

What this PR does / why we need it:
When a cluster owned by CAPZ is deleted, the resource group is deleted entirely, but the vnet remote peering is left in a disconnected state instead of deleted. This is because the remote peering is technically not part of the resource group itself. This PR adds an explicit delete for vnet peerings when the resource group is deleted.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2638

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Cleanup remote peerings when resource group is deleted

[k8s-ci-robot]

Hi @willie-yao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nojnhuh]

/ok-to-test

[willie-yao]

/retest

[willie-yao]

/lifecycle active

[nojnhuh]

/lgtm

[jackfrancis]

/cherry-pick release-1.5
/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5
/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackfrancis]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackfrancis]

/approve

[jackfrancis]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@jackfrancis: #2767 failed to apply on top of branch "release-1.5":

Applying: Cleanup peerings
Using index info to reconstruct a base tree...
M	azure/services/vnetpeerings/vnetpeerings.go
M	azure/services/vnetpeerings/vnetpeerings_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/services/vnetpeerings/vnetpeerings_test.go
CONFLICT (content): Merge conflict in azure/services/vnetpeerings/vnetpeerings_test.go
Auto-merging azure/services/vnetpeerings/vnetpeerings.go
CONFLICT (content): Merge conflict in azure/services/vnetpeerings/vnetpeerings.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup peerings
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5
/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@jackfrancis: new pull request created: #2818

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.