Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shouldnot to codespellignore #2728

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

I have definitive evidence that I work for codespell and not the other way around.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Oct 14, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mboersma October 14, 2022 21:45
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2022
@CecileRobertMichon
Copy link
Contributor

Error: ./.codespellignore:7: ShouldNot ==> should not, shouldn't

hmmmm what?

.codespellignore Outdated
@@ -4,3 +4,4 @@ geting
ot
intepreted
updat
ShouldNot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you try changing this to

Suggested change
ShouldNot
shouldnot

Seems that there is a known bug where it only wants lowercase codespell-project/codespell#2451 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works!

@jackfrancis
Copy link
Contributor Author

@CecileRobertMichon you have my permission to admin merge this if you're looking for more GitHub badge achievements

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Oct 14, 2022

/lgtm
/approve

This fixes it for now. Let's follow up on

  1. Why ShouldNot is getting flagged, it's a common testing word and is a regression in the latest codespell release IMO
  2. Whether we think there is value in keeping codespell enabled in general

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@jackfrancis jackfrancis changed the title add ShouldNot to codespellignore add shouldnot to codespellignore Oct 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit f9a6449 into kubernetes-sigs:main Oct 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 14, 2022
@jackfrancis
Copy link
Contributor Author

/cherry-pick release-1.5

@jackfrancis jackfrancis deleted the codespell-ShouldNot branch November 9, 2022 00:39
@k8s-infra-cherrypick-robot

@jackfrancis: #2728 failed to apply on top of branch "release-1.5":

Applying: add ShouldNot to codespellignore
Using index info to reconstruct a base tree...
M	.codespellignore
Falling back to patching base and 3-way merge...
Auto-merging .codespellignore
CONFLICT (content): Merge conflict in .codespellignore
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add ShouldNot to codespellignore
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants