-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shouldnot to codespellignore #2728
add shouldnot to codespellignore #2728
Conversation
hmmmm what? |
.codespellignore
Outdated
@@ -4,3 +4,4 @@ geting | |||
ot | |||
intepreted | |||
updat | |||
ShouldNot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you try changing this to
ShouldNot | |
shouldnot |
Seems that there is a known bug where it only wants lowercase codespell-project/codespell#2451 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works!
b4598e3
to
4a03b79
Compare
@CecileRobertMichon you have my permission to admin merge this if you're looking for more GitHub badge achievements |
/lgtm This fixes it for now. Let's follow up on
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@jackfrancis: #2728 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
I have definitive evidence that I work for codespell and not the other way around.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: