use cluster name for managed cluster spec's name

[nawazkh]

What type of PR is this?
/kind bug

What this PR does / why we need it:

• With this PR ManagedClusterSpec.name will be set as ManagedControlPlaneScope.Cluster.Name instead of ManagedControlPlaneScope.ControlPlane.Name.
• By doing this, the AzureManagedCluster's Name is independent of AzureManagedControlPlane's Name value.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2438

Special notes for your reviewer:

Current Code flow

1. managedClusterSpec is fetched/formed at this line.

   • cluster-api-provider-azure/azure/services/managedclusters/managedclusters.go

     Line 77 in 240f5dd

     managedClusterSpec := s.Scope.ManagedClusterSpec(ctx)

   • managedClusterSpec.Name's value is set to ManagedControlPlaneScope.ControlPlane.Name which later gets passed down as managedClusterSpec.ResourceName() in 2,3,4 below.

     cluster-api-provider-azure/azure/scope/managedcontrolplane.go

     Line 389 in 240f5dd

     Name: s.ControlPlane.Name,

2. cluster-api-provider-azure/azure/services/managedclusters/managedclusters.go

   Line 97 in 240f5dd

   kubeConfigData, err := s.GetCredentials(ctx, managedClusterSpec.ResourceGroupName(), managedClusterSpec.ResourceName())

3. cluster-api-provider-azure/azure/services/managedclusters/client.go

   Line 66 in 240f5dd

   func (ac *azureClient) GetCredentials(ctx context.Context, resourceGroupName, name string) ([]byte, error) {

4. cluster-api-provider-azure/azure/services/managedclusters/client.go

   Line 70 in 240f5dd

   credentialList, err := ac.managedclusters.ListClusterAdminCredentials(ctx, resourceGroupName, name, "")

Reasoning behind this change.

• Changing the managedClusterSpec.Name's value to ManagedControlPlaneScope.ClusterName() makes managedClusterSpec.Name' independent of ManagedControlPlaneScope.ControlPlane.Name

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

None

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval by writing /assign @cecilerobertmichon in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @nawazkh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nawazkh]

holding the PR for now to add an e2e test case to validate the change.

[nawazkh]

/hold

[jackfrancis]

/ok-to-test

[nawazkh]

/retest

[nawazkh]

/unhold

[nawazkh]

Paired with @CecileRobertMichon to investigate when #2438 issue was not showing up on main branch. We found that #2438 was fixed as part of PR #2168.
Will advise the user to use latest version of CAPZ.

Thank you Cecile!