-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore "latest" for Ubuntu images in test templates #2623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.4 |
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jackfrancis: new pull request created: #2624 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?:
/kind cleanup
What this PR does / why we need it:
In #2618 we pinned some Ubuntu image references to the same Last Known Good version as Windows, but that version doesn't exist for the "capi" Linux offer. I think it should work to leave Ubuntu at "latest" since we have logic that negotiates agreement on a version between Windows and Linux. (Alternately, we can pin these to the correct Ubuntu version, published several days earlier.)
Which issue(s) this PR fixes:
(Bug reported in chat by @lzhecheng.)
Special notes for your reviewer:
Release note: