Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize go imports in test/e2e files #2574

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

mboersma
Copy link
Contributor

What type of PR is this?:

/kind cleanup

What this PR does / why we need it:

Standardizes go import aliases in test/e2e files to follow up on #2529 and #2547.

This is a one-time update which does not enforce this through linting. Enabling linting for all test/e2e code is something we will revisit in a separate PR, because it's a logically separate change (and because it's a big one).

Which issue(s) this PR fixes:

Refs #2289

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

cc: @nojnhuh

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2022
@mboersma
Copy link
Contributor Author

/retest

Provisioning flakes, he said hopefully.

@mboersma mboersma force-pushed the lint-your-way-to-happy branch from 838ee8d to 5e28f2e Compare August 19, 2022 18:36
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2022
@mboersma mboersma force-pushed the lint-your-way-to-happy branch from 5e28f2e to 26f82ce Compare August 22, 2022 19:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2022
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aside from the quantity spelling error

@mboersma mboersma force-pushed the lint-your-way-to-happy branch from 26f82ce to 07b18de Compare August 24, 2022 16:16
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3e4628b into kubernetes-sigs:main Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 24, 2022
@mboersma mboersma deleted the lint-your-way-to-happy branch August 24, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants