-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize go imports in test/e2e files #2574
Standardize go imports in test/e2e files #2574
Conversation
/retest Provisioning flakes, he said hopefully. |
838ee8d
to
5e28f2e
Compare
5e28f2e
to
26f82ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aside from the quantity spelling error
26f82ce
to
07b18de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?:
/kind cleanup
What this PR does / why we need it:
Standardizes go import aliases in test/e2e files to follow up on #2529 and #2547.
This is a one-time update which does not enforce this through linting. Enabling linting for all test/e2e code is something we will revisit in a separate PR, because it's a logically separate change (and because it's a big one).
Which issue(s) this PR fixes:
Refs #2289
Special notes for your reviewer:
TODOs:
Release note:
cc: @nojnhuh