update the node labels for existing AKS nodepools #2559
Conversation
k8s-ci-robot
added
release-note
|
/test pull-cluster-api-provider-azure-e2e-exp |
|
/retest |
| @@ -122,6 +123,7 @@ func (s *Service) Reconcile(ctx context.Context) error { | |||
| EnableAutoScaling: profile.EnableAutoScaling, | |||
| MinCount: profile.MinCount, | |||
| MaxCount: profile.MaxCount, | |||
| NodeLabels: profile.NodeLabels, | |||
There was a problem hiding this comment.
are there any existing unit tests that can be modified to test the behavior this PR fixes?
There was a problem hiding this comment.
I think the agentpool reconcile test could be modified for this. I will update the PR
There was a problem hiding this comment.
added a separate test for normalized diff, as I expect that test to grow when we keep adding more changes with few immutable and some mutable properties to the agentpool
zmalik
force-pushed
the
zm/fix-node-labels-reconcile
branch
from
2d21457 to
e32d7ea
Compare
k8s-ci-robot
added
size/L
|
You might need to rebase since #2529 merged and changed some import names |
zmalik
force-pushed
the
zm/fix-node-labels-reconcile
branch
from
e32d7ea to
9571531
Compare
|
/test pull-cluster-api-provider-azure-e2e-exp |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.4 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jackfrancis: new pull request created: #2569 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
AKS allows updating the node labels for its nodepools, this PR fixes the normalized diff for agentpool of AKS to include the nodelabels.
TODOs:
Release note: