Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public IPs reconcile/delete async #2317

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented May 20, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it: Implementation of an async service for public IPs as a follow up for #1610 and #1541. Thanks to @karuppiah7890 for starting this effort!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1716

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Make public IPs reconcile/delete async

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 20, 2022
@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for kubernetes-sigs-cluster-api-provider-azure pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4efef06

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2022
@Jont828
Copy link
Contributor Author

Jont828 commented May 20, 2022

/assign @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2022
@CecileRobertMichon
Copy link
Contributor

@Jont828 could you please rebase this one?

Is it ready for review?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2022
@Jont828
Copy link
Contributor Author

Jont828 commented Jun 23, 2022

@CecileRobertMichon Yep, I rebased and this should be ready for review!

azure/scope/cluster.go Outdated Show resolved Hide resolved
azure/scope/cluster.go Outdated Show resolved Hide resolved
@Jont828
Copy link
Contributor Author

Jont828 commented Jun 29, 2022

@CecileRobertMichon @jackfrancis I removed the public IP client interface and updated it in the VM service as well. PTAL when you have some time. Thanks!

@CecileRobertMichon
Copy link
Contributor

One more comment about making the AzureClient unexported, otherwise LGTM

please squash commits

@Jont828 Jont828 force-pushed the async-publicips branch from 25a479b to ced144c Compare July 6, 2022 01:16
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@CecileRobertMichon
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 6, 2022

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff ced144c link false /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 453dfbf into kubernetes-sigs:main Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async publicips
4 participants