-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make public IPs reconcile/delete async #2317
Conversation
👷 Deploy request for kubernetes-sigs-cluster-api-provider-azure pending review.Visit the deploys page to approve it
|
/assign @CecileRobertMichon |
@Jont828 could you please rebase this one? Is it ready for review? |
@CecileRobertMichon Yep, I rebased and this should be ready for review! |
@CecileRobertMichon @jackfrancis I removed the public IP client interface and updated it in the VM service as well. PTAL when you have some time. Thanks! |
One more comment about making the AzureClient unexported, otherwise LGTM please squash commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Jont828: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it: Implementation of an async service for public IPs as a follow up for #1610 and #1541. Thanks to @karuppiah7890 for starting this effort!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1716
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: