fix: infinite loop bug in iteration over VM SKU

[alexeldeib]

What this PR does / why we need it:
Fix iteration over fetched resource SKUs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #228

Special notes for your reviewer:
I'm sorry! 😭😭😭

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

fix: infinite loop bug in iteration over VM SKU

[k8s-ci-robot]

Hi @alexeldeib. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alexeldeib]

/hold

[alexeldeib]

@CecileRobertMichon @justaugustus @awesomenix fyi

/hold cancel

[justaugustus]

/ok-to-test

@alexeldeib -- have you had a chance to smoke test this locally?

[justaugustus]

Also, please amend the commit message to actually describe what's being fixed.

[alexeldeib]

My cluster finished building a moment ago (logs). Seeing no second reconciliation loop was kind of the kicker.

Sorry for breaking master :(

[justaugustus]

Thanks for providing logs, @alexeldeib!
/lgtm
/approve

btw, I think it's time for you to apply for org membership :) --> https://github.com/kubernetes/org/issues/new?assignees=&labels=area%2Fgithub-membership&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment