Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a copied code comment #2282

Merged
merged 1 commit into from
May 3, 2022
Merged

Fix a copied code comment #2282

merged 1 commit into from
May 3, 2022

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented May 3, 2022

What type of PR is this?:

/kind documentation

What this PR does / why we need it:

Fixes a code comment that was copied and pasted, but not updated.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from alexeldeib and Jont828 May 3, 2022 20:38
jackfrancis
jackfrancis approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 369fe2a into kubernetes-sigs:main May 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone May 3, 2022
@mboersma mboersma deleted the fix-comment branch May 4, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@jackfrancis jackfrancis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @CecileRobertMichon @k8s-ci-robot @jackfrancis