Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case of userAssignedIdentityID in JSON serialization #2268

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Fix case of userAssignedIdentityID in JSON serialization #2268

merged 1 commit into from
Apr 29, 2022

Conversation

mboersma
Copy link
Contributor

What type of PR is this?:

/kind bug

What this PR does / why we need it:

This extracts an uncontroversial fix from #2214 so it can be merged separately.

Which issue(s) this PR fixes:

Refs #2164
See also kubernetes-sigs/cloud-provider-azure#1290

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix case of userAssignedIdentityID in JSON serialization

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2022
jackfrancis
jackfrancis approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I assume this is safe to do in a breaking way because the current implementation doesn't actually (and never did) work?

@mboersma
Copy link
Contributor Author

mboersma commented Apr 29, 2022 •
edited
Loading

I assume this is safe to do in a breaking way because the current implementation doesn't actually (and never did) work?

Sadly, yes. Here are the documented fields, and CAPZ just had it wrong: https://kubernetes-sigs.github.io/cloud-provider-azure/install/configs/#auth-configs

Secondarily, there is an issue where CAPZ populating this field with the user-assigned ID's "providerID" (URL) wouldn't work with cloud-provider-azure. #2214 addresses that from the CAPZ side, and kubernetes-sigs/cloud-provider-azure#1290 from cloud-provider-azure's side. (I know you know this @jackfrancis, just recapping here.)

That latter fix is being backported to previous releases thanks to your nudging them. Thanks again!

@mboersma
Copy link
Contributor Author

/retest

VMSS provisioning timeout, which I don't think this affects.

CecileRobertMichon
CecileRobertMichon approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jackfrancis feel free to use your "/lgtm" label reviewer powers now that you are officially a reviewer :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2022
jackfrancis
jackfrancis approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 6ae5324 into kubernetes-sigs:main Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Apr 29, 2022
@mboersma mboersma deleted the fix-user-assigned-id-case branch April 29, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@devigned devigned Awaiting requested review from devigned

Assignees

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @jackfrancis @CecileRobertMichon