Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Calico manifests to v3.22.0 #2128

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Update Calico manifests to v3.22.0 #2128

merged 2 commits into from
Mar 1, 2022

Conversation

CecileRobertMichon
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1913

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update Calico manifests to v3.22.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 25, 2022
CecileRobertMichon
CecileRobertMichon commented Feb 25, 2022
View reviewed changes
templates/addons/calico-ipv6.yaml
@@ -314,6 +314,268 @@ status:
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsturtevant these are all the changes made in the ipv6 manifest by the 3.20 -> 3.22 update. Let's see if this PR repros the issue that was happening in #2021

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... I don't see anything that jumps out as different configuration

@CecileRobertMichon
Copy link
Contributor Author

/retest

just in case, but pretty sure this is the same issue as last time

@jsturtevant
Copy link
Contributor

just in case, but pretty sure this is the same issue as last time

The previous error looks like the deployment pod didn't start:

        "reason": "MinimumReplicasUnavailable",
        "message": "Deployment does not have minimum availability."

LAST SEEN                      TYPE    REASON             OBJECT                MESSAGE
2022-02-25 19:49:10 +0000 UTC  Normal  ScalingReplicaSet  deployment/webgt66i4  Scaled up replica set webgt66i4-7887d46cd4 to 1

@jsturtevant
Copy link
Contributor

found:

Feb 25 19:52:14.155999 capz-e2e-ty3nms-ipv6-md-0-5c2fx kubelet[1104]: E0225 19:52:14.155716    1104 pod_workers.go:918] "Error syncing pod, skipping" err="failed to \"CreatePodSandbox\" for \"webgt66i4-7887d46cd4-xcnpg_default(0561d350-1d32-4ab2-85d3-2710a08d5f71)\" with CreatePodSandboxError: \"Failed to create sandbox for pod \\\"webgt66i4-7887d46cd4-xcnpg_default(0561d350-1d32-4ab2-85d3-2710a08d5f71)\\\": rpc error: code = Unknown desc = failed to setup network for sandbox \\\"8fa8ef3b00d43ebe98b1df30d9e9da958d86ede75403282adef971038dddcdc8\\\": plugin type=\\\"calico\\\" failed (add): usePodCidr found but there is no IPv4 CIDR configured\"" pod="default/webgt66i4-7887d46cd4-xcnpg" podUID=0561d350-1d32-4ab2-85d3-2710a08d5f71
Feb 25 19:52:26.177189 capz-e2e-ty3nms-ipv6-md-0-5c2fx kubelet[1104]: E0225 19:52:26.177083    1104 remote_runtime.go:116] "RunPodSandbox from runtime service failed" err="rpc error: code = Unknown desc = failed to setup network for sandbox \"86203b1ad4e9ea791ba34c6dfda6abeaad424e7461f8fa5d8be750d3a8f2bf5b\": plugin type=\"calico\" failed (add): usePodCidr found but there is no IPv4 CIDR configured"

which is configured here

cluster-api-provider-azure/templates/addons/calico-ipv6.yaml

Line 3609 in 6a93006

"subnet": "usePodCidr"

@CecileRobertMichon
Copy link
Contributor Author

Now seeing:

Feb 28 20:04:09.884471 capz-e2e-agi05s-ipv6-md-0-kr9lf kubelet[1142]: E0228 20:04:09.884377    1142 pod_workers.go:918] "Error syncing pod, skipping" err="failed to \"CreatePodSandbox\" for \"webvrg5ho-684d8f8b-g92ss_default(d4c7210c-4b95-4ec5-9e0a-e8f17130ae12)\" with CreatePodSandboxError: \"Failed to create sandbox for pod \\\"webvrg5ho-684d8f8b-g92ss_default(d4c7210c-4b95-4ec5-9e0a-e8f17130ae12)\\\": rpc error: code = Unknown desc = failed to setup network for sandbox \\\"8b20fbb36cbde9eb44363de2aa5fcf0544f33ebe599269396cdbe25bad50e047\\\": plugin type=\\\"calico\\\" failed (add): no IP ranges specified\"" pod="default/webvrg5ho-684d8f8b-g92ss" podUID=d4c7210c-4b95-4ec5-9e0a-e8f17130ae12

@CecileRobertMichon
Copy link
Contributor Author

Looks like there is a usePodCidrIPv6 option, trying that

@CecileRobertMichon
Copy link
Contributor Author

This is the change related to this for the record: https://github.com/projectcalico/calico/pull/5313/files#diff-742c8968cd6af9cdd7510f39e61fe127ce4fa98fe893beb0183837182ec09072R340

@CecileRobertMichon CecileRobertMichon changed the title [WIP] Update Calico manifests to v3.22.0 Update Calico manifests to v3.22.0 Feb 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2022
jsturtevant
jsturtevant reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

templates/addons/calico/patches/remove-aws-reference.yaml
# json patch doesn't allow for dropping fields in array by name
# https://github.com/projectcalico/calico/issues/5101
- op: remove
path: "/spec/template/spec/containers/0/env/12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that we get to drop this! fyi @jackfrancis

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@jsturtevant
Copy link
Contributor

/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

@CecileRobertMichon
Copy link
Contributor Author

Init container clonerefs not ready: (state: waiting, reason: "PodInitializing", message: "") Init container initupload not ready: (state: waiting, reason: "PodInitializing", message: "") Init container place-entrypoint not ready: (state: waiting, reason: "PodInitializing", message: "")

prow pod timeout

/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

@CecileRobertMichon
Copy link
Contributor Author

all tests passed

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit d241f82 into kubernetes-sigs:main Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Mar 1, 2022
@CecileRobertMichon CecileRobertMichon deleted the calico-3.22 branch February 17, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@juan-lee juan-lee Awaiting requested review from juan-lee

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Update Calico manifests to latest version
3 participants
@CecileRobertMichon @jsturtevant @k8s-ci-robot