enable/disable AKS cluster add-ons

[michalno1]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR allows enabling/disabling AKS cluster add-ons.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1145

Release note:

Support enabling and disabling AKS cluster add-ons.

[k8s-ci-robot]

Hi @michalno1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zmalik]

/area managedclusters

[zmalik]

/ok-to-test

[jackfrancis]

code lgtm

Can we add some test coverage to the AKS spec we run tests against at templates/flavors/aks-multi-tenancy/cluster-template.yaml?

Is there a "simple" addon we can enable in the AzureManagedControlPlane resource spec to test this new functionality that won't change any other functional aspects of the cluster?

After making that change run make generate-flavors to render the final template for prow CI to consume and be able to test.

Thanks!

[CecileRobertMichon]

Can we add some test coverage to the AKS spec we run tests against at templates/flavors/aks-multi-tenancy/cluster-template.yaml?

Heads up I'm removing the multi-tenancy flavor in #2143 to replace it with the regular "aks" flavor since all templates have multi-tenancy now, it's redundant to have a separate "multi-tenancy" flavor. Going forward we'll be testing with https://github.com/kubernetes-sigs/cluster-api-provider-azure/tree/ab1aec6f47646a1f03839b4a4e1b3047cf3aea42/templates/test/ci/prow-aks.

[michalno1]

@jackfrancis From the addons that can be used I think a good one for testing is azurepolicy- it shouldn't interfere with functional aspects of the cluster. Another good one would be monitoring but it does require creating a Log Analytics Workspace first. I'll use azurepolicy for now.

@jackfrancis @CecileRobertMichon It seems to me existing e2e tests just check if everything started successfully. Shouldn't they also somehow verify flavor specific settings are really in effect?

[jackfrancis]

@michalno1 I have a slight preference for not testing functional outcomes and instead relying upon the AKS API to do that if it accepts our requests. The only reason is that it would add test maintenance for outcomes outside of our control (i.e., AKS operational behaviors).

But it's not a simple issue, as the project would benefit having more coverage signal to add customer confidence that "this particular way of using AKS will have the desired effect".

[CecileRobertMichon]

Ideally we shouldn't enable features for tests directly in the flavors as those are also exposed as examples for users, but we can add patches in the test/ directory for that sort of stuff

since this is likely to merge before #2143 and I'm removing this template anyways, let's keep this for now and I'll do some cleanup in my PR.

[jackfrancis]

/lgtm

[jackfrancis]

/assign @CecileRobertMichon

[CecileRobertMichon]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment