Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor api/*/tags.go to move annotation name constants to azure/const.go #2060

Merged
merged 1 commit into from
Feb 15, 2022
Merged

refactor api/*/tags.go to move annotation name constants to azure/const.go #2060

merged 1 commit into from
Feb 15, 2022

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Feb 9, 2022 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactors api/*/tags.go to move VMTagsLastAppliedAnnotation and RGTagsLastAppliedAnnotation to azure/const.go

Which issue(s) this PR fixes :
Fixes #1789

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Deprecated: infrav1.RGTagsLastAppliedAnnotation, infrav1.VMTagsLastAppliedAnnotation will be removed in v1beta2. Use azure.RGTagsLastAppliedAnnotation, azure.VMTagsLastAppliedAnnotation instead.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 9, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 9, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @nawazkh!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nawazkh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 9, 2022
@nawazkh
Copy link
Member Author

nawazkh commented Feb 9, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@nawazkh
Copy link
Member Author

nawazkh commented Feb 9, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@mboersma
Copy link
Contributor

mboersma commented Feb 9, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2022
@nawazkh
Copy link
Member Author

nawazkh commented Feb 9, 2022

/retest

devigned
devigned approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice work, @nawazkh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@nawazkh
Copy link
Member Author

nawazkh commented Feb 10, 2022 •
edited
Loading

PR is failing the go-apidiff test
Details:

*** Running go-apidiff ***

sigs.k8s.io/cluster-api-provider-azure/api/v1alpha4
  Incompatible changes:
  - VMTagsLastAppliedAnnotation: removed

sigs.k8s.io/cluster-api-provider-azure/azure
  Compatible changes:
  - RGTagsLastAppliedAnnotation: added
  - VMTagsLastAppliedAnnotation: added

sigs.k8s.io/cluster-api-provider-azure/api/v1alpha3
  Incompatible changes:
  - VMTagsLastAppliedAnnotation: removed

sigs.k8s.io/cluster-api-provider-azure/api/v1beta1
  Incompatible changes:
  - RGTagsLastAppliedAnnotation: removed
  - VMTagsLastAppliedAnnotation: removed

Since a bunch of exposed constants were moved around (from api/ to azure/), it could be a breaking change for CAPZ users.

Any comments/suggestions on making headway ?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@nawazkh
Copy link
Member Author

nawazkh commented Feb 15, 2022

/retest

@CecileRobertMichon
Copy link
Contributor

lgtm

Please squash commits and add a release note

/retest

@nawazkh
refactor annotation name constants from api/v1beta1/tags.go
55e72bd 
- add VMTagsLastAppliedAnnotation, RGTagsLastAppliedAnnotation to azure/const.go
- add deprecated message to the named constants
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 15, 2022
CecileRobertMichon
CecileRobertMichon approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thank you @nawazkh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit d8cf282 into kubernetes-sigs:main Feb 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Feb 15, 2022
@nawazkh nawazkh deleted the nhk/1789 branch February 15, 2022 22:50
@nawazkh nawazkh mentioned this pull request Nov 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee

@mboersma mboersma Awaiting requested review from mboersma

@devigned devigned Awaiting requested review from devigned

Assignees

@devigned devigned

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Move annotation name constants out of api/
5 participants
@nawazkh @k8s-ci-robot @mboersma @CecileRobertMichon @devigned