Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: debugging information added #2053

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Documentation added on how to debug CAPZ using tilt.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #588

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Added documentation on debugging using Tilt.

Documentation added on how to debug CAPZ using tilt

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 7, 2022
@mboersma
Copy link
Contributor

mboersma commented Feb 7, 2022

This also fixes #1801.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@mboersma
Copy link
Contributor

mboersma commented Feb 7, 2022

This is great, thanks @richardcase!

By coincidence, I actually started making similar changes to enable debugging like this in the CAPZ-only setup. Would that also be useful, or should we just stick with CAPI's debugging configuration?

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 87aee45 into kubernetes-sigs:main Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Feb 8, 2022
@richardcase
Copy link
Member Author

This is great, thanks @richardcase!

By coincidence, I actually started making similar changes to enable debugging like this in the CAPZ-only setup. Would that also be useful, or should we just stick with CAPI's debugging configuration?

@mboersma - i think we must have both seen the stale notification. It reminded me i hadn't done it. I like the consistency that the CAPI debug configuration gives as i can use that for CAPZ, CAPA, core etc. But guessing if there is benefit to something specific to CAPZ that could be be an addition?

@mboersma
Copy link
Contributor

mboersma commented Feb 8, 2022

Benefits to having a CAPZ-specific debugging configuration for Tilt would be convenience and keeping the project self-contained (although we document the CAPI+CAPZ debugging configuration already, obviously). But I'm not sure that outweighs the added complexity in CAPZ's Tiltfile, and it may be preferable to have one official way to debug CAPZ, which you have documented.

So I think I've talked myself out of it, but if you or anyone reading this sees more value in having a debugging configuration for the "Tilt with CAPZ" developer story, please say so. I'll keep the changes around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve local debugging experience
5 participants