Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced go get with go install to install binaries #2008

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Replaced go get with go install to install binaries #2008

merged 1 commit into from
Feb 18, 2022

Conversation

jayesh-srivastava
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The PR replaces go get with go install to install binaries.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2004

Release note:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022
@jayesh-srivastava jayesh-srivastava changed the title Replaced go get with go install Replaced go get with go install to install binaries Jan 26, 2022
@jayesh-srivastava
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 26, 2022
@jayesh-srivastava
Copy link
Member Author

/test pull-cluster-api-provider-azure-e2e

@CecileRobertMichon
Copy link
Contributor

It looks like there is a known issue with kustomize that prevents us from using go install with it: kubernetes-sigs/kustomize#3618

we can either wait until it's fixed to merge this, or change the kustomize install to keep using go get for now.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@sonasingh46
Copy link
Contributor

sonasingh46 commented Feb 3, 2022 •
edited
Loading

@CecileRobertMichon -- I was thinking we can probably use go install to install binary for all other tools and for kustomize we can still use go get.

@sonasingh46
Copy link
Contributor

We can use hard coded go get here for kustomize
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/Makefile#L255

@sonasingh46
Copy link
Contributor

sonasingh46 commented Feb 3, 2022 •
edited
Loading

we can either wait until it's fixed to merge this, or change the kustomize install to keep using go get for now.

I think you suggested the same, Cecile. Sorry for duplicating, missed it.

@CecileRobertMichon
Copy link
Contributor

#2088 should unblock this

@jayesh-srivastava
Copy link
Member Author

jayesh-srivastava commented Feb 16, 2022 •
edited
Loading

/remove-hold

@jayesh-srivastava
Copy link
Member Author

@CecileRobertMichon I guess I can't remove the hold. Now that #2091 is merged, I think this should work now.

@CecileRobertMichon
Copy link
Contributor

/retest

@CecileRobertMichon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2022
@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

Thanks @jayesh-srivastava!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@devigned
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4fa6e63 into kubernetes-sigs:main Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Feb 18, 2022
@displague displague mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@devigned devigned Awaiting requested review from devigned

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Use go install instead of go get to install binaries
5 participants
@jayesh-srivastava @CecileRobertMichon @sonasingh46 @k8s-ci-robot @devigned