Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (4/15/19) #184

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

justaugustus
Copy link
Member

Signed-off-by: Stephen Augustus [email protected]

What this PR does / why we need it:
Update dependencies:

Gopkg.toml

  • Azure/azure-sdk-for-go: 26.6.0 -> 27.1.0

WORKSPACE

  • rules_go: 0.18.1 -> 0.18.3
  • bazel-gazelle: 0.16.0 -> 0.17.0
  • golang: 1.11.5 -> 1.12.4
  • golangci-lint: v1.15.0 -> v1.16.0
  • kind: 91d92c86cfa4143143841aad7f9b6d0c35e109ea -> 161151a26faf0dbe962ac9f323cc0cdebac79ba8
  • Kubernetes: v1.13.5 -> v1.14.1

Packages

  • containerd: 1.2.4 -> 1.2.6 (set constants in config package)
  • Azure/compute: 2018-10-01/compute -> 2019-03-01/compute

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related #168

Special notes for your reviewer:

This moves the version bumps for v0.2.0 to another PR, since there are still some things to land before releasing the next version. I'd like to get these in beforehand.

Additionally, I was not able to bump github.com/Azure/go-autorest from 11.5.2 to 11.7.1 due to this error:

/home/augustus/.cache/bazel/_bazel_augustus/bd8987116252386267e76c13b740e64e/sandbox/linux-sandbox/16/execroot/__main__/vendor/contrib.go.opencensus.io/exporter/ocagent/ocagent.go:299:38: undefined: "sigs.k8s.io/cluster-api-provider-azure/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ALWAYS_ON
/home/augustus/.cache/bazel/_bazel_augustus/bd8987116252386267e76c13b740e64e/sandbox/linux-sandbox/16/execroot/__main__/vendor/contrib.go.opencensus.io/exporter/ocagent/transform_stats_to_metrics.go:52:3: unknown field 'MetricDescriptor' in struct literal of type "sigs.k8s.io/cluster-api-provider-azure/vendor/github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric

which suggests there are still issues with the dependencies in go-autorest. (ref: Azure/go-autorest#375, Azure/go-autorest#376, Azure/go-autorest#377)

Release note:

NONE

Gopkg.toml
- Azure/azure-sdk-for-go: 26.6.0 -> 27.1.0

WORKSPACE
- rules_go: 0.18.1 -> 0.18.3
- bazel-gazelle: 0.16.0 -> 0.17.0
- golang: 1.11.5 -> 1.12.4
- golangci-lint: v1.15.0 -> v1.16.0
- kind: 91d92c86cfa4143143841aad7f9b6d0c35e109ea -> 161151a26faf0dbe962ac9f323cc0cdebac79ba8
- Kubernetes: v1.13.5 -> v1.14.1

Packages
- containerd: 1.2.4 -> 1.2.6 (set constants in config package)
- Azure/compute: 2018-10-01/compute -> 2019-03-01/compute

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2019
@justaugustus
Copy link
Member Author

/assign @soggiest @awesomenix
/priority important-soon
/milestone v1alpha1

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Apr 15, 2019
Copy link
Contributor

@soggiest soggiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0345fdf into kubernetes-sigs:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants