Update Service interface to use Reconcile/Delete methods #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
approved
Signed-off-by: Stephen Augustus <[email protected]>
k8s-ci-robot
added
release-note
justaugustus
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ready for review. |
soggiest
reviewed
Apr 11, 2019
awesomenix
suggested changes
Apr 11, 2019
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awesomenix, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Augustus [email protected]
What this PR does / why we need it:
CreateOrUpdate/ReconcileGetterServiceinterface, a temporary interface to represent services that still require Get methodsvar _ azure.Service = (*Service)(nil)) to each Azure service, which will force compilation errors if an Azure service doesn't satisfy theServiceinterfaceWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related: #110, #174, #177
Special notes for your reviewer:
This is largely a search and replace, so no additional tests are required.
As we refactor the individual lower-level reconcilers, we'll add unit tests alongside.
Release note:
/milestone v1alpha1
/priority important-soon
/kind design