-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align comments to behavior #179
Conversation
Welcome @alexeldeib! |
Hi @alexeldeib. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks for PR, looking forward for more contributions. @alexeldeib |
This is great. Thanks for fixing the comments up, @alexeldeib! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeldeib, awesomenix, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Probably one of the less helpful PRs of all time...While familiarizing myself with the code I noticed a bunch of the comments were misaligned to their behavior. This PR is simply to fix the comments. Hopefully i'll be able to contribute something more productive in the future 😄
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: