-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture test case range variable before running sub test in parallel #1777
Conversation
Hi @karuppiah7890. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Karuppiah Natarajan <[email protected]>
Signed-off-by: Karuppiah Natarajan <[email protected]>
85fbf56
to
71c3fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of resolving the TODOs, the PR lgtm.
Signed-off-by: Karuppiah Natarajan <[email protected]>
71c3fcd
to
4ffc946
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Nice work. Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1760
Special notes for your reviewer:
TODOs:
bastion_hosts_test.go
file #1754 . I can rebase this PR with main once Fix tests inbastion_hosts_test.go
file #1754 is mergedbastion_hosts_test.go
file #1754 . I can rebase this PR with main once Fix tests inbastion_hosts_test.go
file #1754 is mergedRelease note: