-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node role #170
Add node role #170
Conversation
Hi @tahsinrahman. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tahsinrahman -- thanks for this! Would you mind also supplying a redacted version of your machines.yaml? I see you're using a node pool here for the workers and would like to take a look. /ok-to-test |
@justaugustus sure, i created this using machineset, here's the yaml
|
Thanks for that! Are you adding it as part of the machines.yaml or deploying the MachineSet after the cluster has come up? Could you please also add a release note to the PR description: #170 (comment) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, tahsinrahman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I deployed machineset after creating cluster with a single master |
Awesome! Thanks again. :) |
What this PR does / why we need it:
Add roles to nodes
instead of
ref: kubernetes-sigs/cluster-api-provider-aws#681
Release note: