Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node role #170

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Conversation

tahsinrahman
Copy link
Contributor

@tahsinrahman tahsinrahman commented Apr 3, 2019

What this PR does / why we need it:
Add roles to nodes

NAME                       STATUS     ROLES    AGE     VERSION
az101-master               Ready      master   6m15s   v1.13.4
standard-b2ms-pool-j92hc   Ready      node     45s     v1.13.4

instead of

NAME                       STATUS     ROLES    AGE     VERSION
az101-master               Ready      master   6m15s   v1.13.4
standard-b2ms-pool-j92hc   Ready      <none>   45s     v1.13.4

ref: kubernetes-sigs/cluster-api-provider-aws#681

Release note:

Add node roles to non-controlplane nodes

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2019
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tahsinrahman. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Contributor

@tahsinrahman -- thanks for this! Would you mind also supplying a redacted version of your machines.yaml? I see you're using a node pool here for the workers and would like to take a look.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2019
@tahsinrahman
Copy link
Contributor Author

@justaugustus sure, i created this using machineset, here's the yaml

kind: MachineSet
apiVersion: cluster.k8s.io/v1alpha1
metadata:
  name: standard-b2ms-pool
  creationTimestamp: '2019-04-03T14:09:46Z'
spec:
  replicas: 1
  selector:
    matchLabels:
      cluster.k8s.io/cluster-name: az101
  template:
    metadata:
      creationTimestamp: '2019-04-03T14:09:46Z'
      labels:
        cluster.k8s.io/cluster-name: az101
        node-role.kubernetes.io/node: ''
        set: node
    spec:
      providerSpec:
        value:
          kind: AzureMachineProviderSpec
          apiVersion: azureprovider/v1alpha1
          metadata:
            creationTimestamp: 
          roles:
          - Node
          location: eastus2
          vmSize: Standard_B2ms
          image:
            publisher: Canonical
            offer: UbuntuServer
            sku: 16.04-LTS
            version: latest
          osDisk:
            osType: Linux
            managedDisk:
              storageAccountType: Premium_LRS
            diskSizeGB: 30
          sshPublicKey: <pubkey>
          sshPrivateKey: <privkey>
      versions:
        kubelet: 1.13.4

@justaugustus
Copy link
Contributor

Thanks for that! Are you adding it as part of the machines.yaml or deploying the MachineSet after the cluster has come up?

Could you please also add a release note to the PR description: #170 (comment)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, tahsinrahman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
@tahsinrahman
Copy link
Contributor Author

I deployed machineset after creating cluster with a single master

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0aec2b5 into kubernetes-sigs:master Apr 3, 2019
@justaugustus
Copy link
Contributor

Awesome! Thanks again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants