Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make group delete async #1667

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Make group delete async #1667

merged 2 commits into from
Sep 17, 2021

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Sep 1, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it: Follow up on #1610, this PR enables async reconcile for groups. See #1541 for the proposal.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

/hold

will rebase on top of #1610 once it merges.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Make group delete async

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Sep 1, 2021
@CecileRobertMichon
Copy link
Contributor Author

CecileRobertMichon commented Sep 1, 2021 •
edited
Loading

9770c7c is the relevant commit for this PR (the other changes are already part of #1610)

@CecileRobertMichon CecileRobertMichon force-pushed the async-groups branch 6 times, most recently from 502b8ce to 9770c7c Compare September 7, 2021 21:33
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2021
@CecileRobertMichon CecileRobertMichon changed the title Make group reconcile/delete async Make group delete async Sep 14, 2021
@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@CecileRobertMichon
Copy link
Contributor Author

/retest

1 similar comment
@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor Author

/assign @shysank @devigned

CecileRobertMichon
CecileRobertMichon commented Sep 14, 2021
View reviewed changes
api/v1alpha4/conditions_consts.go
@@ -20,6 +20,8 @@ import clusterv1 "sigs.k8s.io/cluster-api/api/v1alpha4"

// AzureCluster Conditions and Reasons.
const (
// NetworkInfrastructureReadyCondition reports of current status of cluster infrastructure.
NetworkInfrastructureReadyCondition clusterv1.ConditionType = "NetworkInfrastructureReady"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-added so that the cluster doesn't show as Ready until all services are done reconciling (might remove once each service has its own condition in place to use as summary)

shysank
shysank reviewed Sep 15, 2021
View reviewed changes
azure/services/groups/groups.go Outdated Show resolved Hide resolved
azure/services/groups/spec.go Outdated Show resolved Hide resolved
controllers/azurecluster_controller.go Show resolved Hide resolved
azure/services/groups/groups.go Show resolved Hide resolved
@shysank
Copy link
Contributor

shysank commented Sep 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@CecileRobertMichon
Copy link
Contributor Author

would be great to get a second lgtm on this if anyone has time to put some 👀 on it

@nader-ziada @devigned @whites11

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@CecileRobertMichon
Copy link
Contributor Author

I changed the service name from "groups" to "group" so it reads "group deleting" instead of "groups deleting" in the logs (there is always only one group per cluster)

devigned
devigned suggested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions. Overall looks great!

azure/services/groups/client.go Show resolved Hide resolved
azure/services/groups/spec.go Show resolved Hide resolved
@nader-ziada
Copy link
Contributor

lgtm, pending David's comments

devigned
devigned approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor Author

/retest

windows vmss flake

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2021 •
edited
Loading

@CecileRobertMichon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-azure-apidiff 6ae407c link /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 429ede2 into kubernetes-sigs:main Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 17, 2021
@shysank shysank mentioned this pull request Sep 20, 2021
Closed
23 tasks
@karuppiah7890 karuppiah7890 mentioned this pull request Sep 21, 2021
Closed
@CecileRobertMichon CecileRobertMichon deleted the async-groups branch February 17, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shysank shysank shysank left review comments

@nader-ziada nader-ziada nader-ziada left review comments

@devigned devigned devigned approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@devigned devigned

@shysank shysank

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@CecileRobertMichon @shysank @nader-ziada @k8s-ci-robot @devigned