-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release via Github Action #1624
Automate release via Github Action #1624
Conversation
04a4bec
to
586a7c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one question about Go version.
/cc @alexeldeib |
/retest |
@devigned @alexeldeib any other comments on this? I'd like to get it merged so I can use it to release v0.5.2 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it: Makes the release process more automated. Pushing a tag will automatically cause a draft release to be created with needed artifacts and auto-generated release notes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1569
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Tested on my fork: https://github.com/CecileRobertMichon/cluster-api-provider-azure/runs/3356321723?check_suite_focus=true
Resulting release - not sure if this is visible to all: https://github.com/CecileRobertMichon/cluster-api-provider-azure/releases/tag/untagged-aa4bb391782dcc5daa9e (empty release notes because no changes)
TODOs:
Release note: