-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix managed clusters custom VNet delete issue #1598
fix managed clusters custom VNet delete issue #1598
Conversation
Hi @LochanRn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
lgtm |
I believe you can check "squashed commits" and "adds unit tests" in PR description. Adding a release note would also be useful. |
updated the comment message
3720b30
to
d411a1d
Compare
Are you sure you want me to add a release note ? Like isn't the title enough ? |
Oh if the PR title gets added automatically then great (didn't know that). |
/lgtm nice catch 👍 |
The PR title isn't enough, release notes are auto-generated from the "release note" block in the PR description (we use https://github.com/kubernetes/release/tree/master/cmd/release-notes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Hoping the job flakes become less frequent now that #1588 merged |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we create managed clusters using custom vnet on cluster delete custom vnet also gets deleted.
Custom vnets are not managed by capz and they should not be deleted while deleting the managed clusters
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1590
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: