Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix managed clusters custom VNet delete issue #1598

Conversation

LochanRn
Copy link
Member

@LochanRn LochanRn commented Aug 10, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
When we create managed clusters using custom vnet on cluster delete custom vnet also gets deleted.
Custom vnets are not managed by capz and they should not be deleted while deleting the managed clusters

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1590

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix managed clusters custom VNet delete issue

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @LochanRn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 10, 2021
@alexeldeib
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2021
@nprokopic
Copy link
Contributor

lgtm

@nprokopic
Copy link
Contributor

I believe you can check "squashed commits" and "adds unit tests" in PR description. Adding a release note would also be useful.

@LochanRn LochanRn force-pushed the fix-managedclusters-custom-vnet-delete branch from 3720b30 to d411a1d Compare August 11, 2021 13:43
@LochanRn
Copy link
Member Author

I believe you can check "squashed commits" and "adds unit tests" in PR description. Adding a release note would also be useful.

Are you sure you want me to add a release note ? Like isn't the title enough ?

@nprokopic
Copy link
Contributor

Oh if the PR title gets added automatically then great (didn't know that).

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 11, 2021
@alexeldeib
Copy link
Contributor

/lgtm

nice catch 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@CecileRobertMichon
Copy link
Contributor

Are you sure you want me to add a release note ? Like isn't the title enough ?

The PR title isn't enough, release notes are auto-generated from the "release note" block in the PR description (we use https://github.com/kubernetes/release/tree/master/cmd/release-notes)

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@CecileRobertMichon
Copy link
Contributor

/retest

Hoping the job flakes become less frequent now that #1588 merged

@k8s-ci-robot k8s-ci-robot merged commit 4f0e0fc into kubernetes-sigs:master Aug 13, 2021
@LochanRn LochanRn deleted the fix-managedclusters-custom-vnet-delete branch August 21, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure managed cluster created using a existing VNet on deletion deletes the existing VNet
5 participants