Availability zones support for managed clusters #1564

LochanRn · 2021-07-28T07:10:16Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
It adds availability zones support for managedclusters/agentpools in capz

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1559

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

availabilityZones spec added to AzureManagedMachinePool

k8s-ci-robot · 2021-07-28T07:10:24Z

Hi @LochanRn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CecileRobertMichon · 2021-07-28T22:51:56Z

/ok-to-test

LochanRn · 2021-07-29T06:52:04Z

/test pull-cluster-api-provider-azure-e2e-exp

nprokopic · 2021-08-05T15:24:05Z

Looks good to me.

nprokopic · 2021-08-05T15:32:40Z

In the future it would be nice to add checks if the region that the cluster is being deployed to supports multiple availability zones, since not all regions support them https://docs.microsoft.com/en-us/azure/availability-zones/az-region#azure-regions-with-availability-zones.

nprokopic · 2021-08-06T10:09:57Z

exp/api/v1alpha4/azuremanagedmachinepool_types.go

@@ -42,6 +42,9 @@ type AzureManagedMachinePoolSpec struct {
 	// +kubebuilder:validation:Enum=System;User
 	Mode string `json:"mode"`

+	// AvailabilityZones - Availability zones for nodes. Must use VirtualMachineScaleSets AgentPoolType.
+	AvailabilityZones *[]string `json:"availabilityZones,omitempty"`


To copy-paste @alexeldeib's nit from AAD PR, maybe just a slice instead of pointer to a slice could do the job here.

LochanRn · 2021-08-09T19:39:31Z

/test pull-cluster-api-provider-azure-e2e-exp

LochanRn · 2021-10-26T04:03:40Z

/test pull-cluster-api-provider-azure-e2e-exp

LochanRn · 2021-10-26T04:42:45Z

/test pull-cluster-api-provider-azure-e2e-exp

devigned

lgtm, outside of some optional tags.

exp/api/v1alpha4/azuremanagedmachinepool_types.go

exp/api/v1alpha3/azuremanagedmachinepool_types.go

exp/api/v1beta1/azuremanagedmachinepool_types.go

devigned · 2021-10-26T17:41:32Z

/lgtm cancel

CecileRobertMichon · 2021-11-18T19:47:33Z

/area managedclusters

devigned

lgtm! Nice work, @LochanRn.

/assign @CecileRobertMichon

CecileRobertMichon · 2021-11-19T18:38:28Z

/approve

k8s-ci-robot · 2021-11-19T18:38:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

removed az in v1a3 and v1a4

k8s-ci-robot · 2021-11-21T00:21:32Z

@LochanRn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	`3848ded`	link	false	`/test pull-cluster-api-provider-azure-apidiff`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LochanRn · 2021-11-21T06:27:00Z

/test pull-cluster-api-provider-azure-e2e-windows-dockershim

LochanRn · 2021-11-22T06:34:34Z

@CecileRobertMichon @devigned I think the PR needs a lgtm

CecileRobertMichon

/lgtm

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider labels Jul 28, 2021

k8s-ci-robot requested review from devigned and juan-lee July 28, 2021 07:10

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 28, 2021

LochanRn force-pushed the aks-availabilityzones branch from 98e1b92 to b1bc1c5 Compare July 28, 2021 09:26

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2021

LochanRn mentioned this pull request Aug 5, 2021

REQUEST: New membership for LochanRn kubernetes/org#2875

Closed

7 tasks

nprokopic reviewed Aug 6, 2021

View reviewed changes

nprokopic mentioned this pull request Aug 6, 2021

REQUEST: New membership for nprokopic kubernetes/org#2879

Closed

7 tasks

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2021

LochanRn force-pushed the aks-availabilityzones branch from b1bc1c5 to 61d3332 Compare August 9, 2021 16:21

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2021

LochanRn force-pushed the aks-availabilityzones branch 3 times, most recently from 6cfcbd1 to 29fe21a Compare August 9, 2021 18:25

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021

LochanRn force-pushed the aks-availabilityzones branch from 29fe21a to 1a91b44 Compare August 14, 2021 07:24

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2021

devigned reviewed Oct 26, 2021

View reviewed changes

exp/api/v1alpha4/azuremanagedmachinepool_types.go Outdated Show resolved Hide resolved

exp/api/v1alpha3/azuremanagedmachinepool_types.go Outdated Show resolved Hide resolved

exp/api/v1beta1/azuremanagedmachinepool_types.go Show resolved Hide resolved

k8s-ci-robot assigned devigned Oct 26, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021

LochanRn force-pushed the aks-availabilityzones branch from a76ee81 to 48cc156 Compare October 27, 2021 04:12

LochanRn force-pushed the aks-availabilityzones branch from 48cc156 to c0178f5 Compare November 15, 2021 17:07

k8s-ci-robot added the area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type label Nov 18, 2021

LochanRn force-pushed the aks-availabilityzones branch from c0178f5 to ad4276e Compare November 19, 2021 14:06

devigned approved these changes Nov 19, 2021

View reviewed changes

k8s-ci-robot assigned CecileRobertMichon Nov 19, 2021

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 19, 2021

availability zones support for managedclusters

3848ded

removed az in v1a3 and v1a4

LochanRn force-pushed the aks-availabilityzones branch from ad4276e to 3848ded Compare November 20, 2021 22:05

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2021

CecileRobertMichon reviewed Nov 22, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2021

k8s-ci-robot merged commit 7c4ceec into kubernetes-sigs:main Nov 22, 2021

k8s-ci-robot added this to the v1.1 milestone Nov 22, 2021

CecileRobertMichon mentioned this pull request Dec 9, 2021

Enable more optional configurations for AKS node pools #1706

Closed

3 tasks

LochanRn deleted the aks-availabilityzones branch August 21, 2022 06:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Availability zones support for managed clusters #1564

Availability zones support for managed clusters #1564

LochanRn commented Jul 28, 2021 •

edited

Loading

k8s-ci-robot commented Jul 28, 2021

CecileRobertMichon commented Jul 28, 2021

LochanRn commented Jul 29, 2021

nprokopic commented Aug 5, 2021

nprokopic commented Aug 5, 2021

nprokopic Aug 6, 2021

LochanRn Aug 6, 2021

LochanRn commented Aug 9, 2021

LochanRn commented Oct 26, 2021

LochanRn commented Oct 26, 2021

devigned left a comment •

edited

Loading

devigned commented Oct 26, 2021

CecileRobertMichon commented Nov 18, 2021

devigned left a comment

CecileRobertMichon commented Nov 19, 2021

k8s-ci-robot commented Nov 19, 2021

k8s-ci-robot commented Nov 21, 2021 •

edited

Loading

LochanRn commented Nov 21, 2021

LochanRn commented Nov 22, 2021

CecileRobertMichon left a comment

Availability zones support for managed clusters #1564

Availability zones support for managed clusters #1564

Conversation

LochanRn commented Jul 28, 2021 • edited Loading

k8s-ci-robot commented Jul 28, 2021

CecileRobertMichon commented Jul 28, 2021

LochanRn commented Jul 29, 2021

nprokopic commented Aug 5, 2021

nprokopic commented Aug 5, 2021

nprokopic Aug 6, 2021

Choose a reason for hiding this comment

LochanRn Aug 6, 2021

Choose a reason for hiding this comment

LochanRn commented Aug 9, 2021

LochanRn commented Oct 26, 2021

LochanRn commented Oct 26, 2021

devigned left a comment • edited Loading

Choose a reason for hiding this comment

devigned commented Oct 26, 2021

CecileRobertMichon commented Nov 18, 2021

devigned left a comment

Choose a reason for hiding this comment

CecileRobertMichon commented Nov 19, 2021

k8s-ci-robot commented Nov 19, 2021

k8s-ci-robot commented Nov 21, 2021 • edited Loading

LochanRn commented Nov 21, 2021

LochanRn commented Nov 22, 2021

CecileRobertMichon left a comment

Choose a reason for hiding this comment

LochanRn commented Jul 28, 2021 •

edited

Loading

devigned left a comment •

edited

Loading

k8s-ci-robot commented Nov 21, 2021 •

edited

Loading