Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: custom K8s build on machine pool #1419

Merged
merged 1 commit into from
Jun 8, 2021
Merged

test: custom K8s build on machine pool #1419

merged 1 commit into from
Jun 8, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Jun 7, 2021

Signed-off-by: Ernest Wong [email protected]

What type of PR is this?

/kind other

What this PR does / why we need it:

Follow-up PR for #1264 and #1383.

  • Add a cluster template for custom K8s build on machine pool
  • populate nil-valued cluster in AfterSuite of conformance_test.go so we can collect machine boot log if cluster provision failed

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

@chewong: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Ernest Wong [email protected]

What type of PR is this?

/kind other

What this PR does / why we need it:

Follow-up PR for #1264 and #1383.

  • Add a cluster template for custom K8s build on machine pool
  • populate nil-valued cluster in AfterSuite of conformance_test.go so we can collect machine boot log if cluster provision failed

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 7, 2021
@@ -169,6 +170,11 @@ var _ = Describe("Conformance Tests", func() {
}, 1)

AfterEach(func() {
if cluster == nil {
// this means the cluster failed to come up. We make an attempt to find the cluster to be able to fetch logs for the failed bootstrapping.
_ = bootstrapClusterProxy.GetClient().Get(ctx, types.NamespacedName{Name: clusterName, Namespace: namespace.Name}, cluster)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, forgot to do this in #1383

@CecileRobertMichon
Copy link
Contributor

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@chewong
Copy link
Member Author

chewong commented Jun 7, 2021

/retest

1 similar comment
@chewong
Copy link
Member Author

chewong commented Jun 7, 2021

/retest

@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot merged commit 745c25e into kubernetes-sigs:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Jun 8, 2021
@chewong chewong deleted the custom-build-mp branch June 8, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants