🐛 Make cloud config secret key backward compatible #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/cluster-lifecycle
|
/test pull-cluster-api-provider-azure-e2e-windows-release-0-4 |
|
/lgtm re-running the windows test to get past the timeout |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
controllers/helpers.go
Outdated
| @@ -188,6 +188,7 @@ func GetCloudProviderSecret(d azure.ClusterScoper, namespace, name string, owner | |||
| secret.Data = map[string][]byte{ | |||
| "control-plane-azure.json": controlPlaneData, | |||
| "worker-node-azure.json": workerNodeData, | |||
| "azure.json": controlPlaneData, | |||
There was a problem hiding this comment.
/hold
can you please add a code comment that says this is included for backward compatibility?
k8s-ci-robot
added
the
do-not-merge/hold
shysank
changed the title
shysank
force-pushed
the
azure_json_backwards_compatible
branch
from
44c6b8a to
e5358b8
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel thanks @shysank |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Copies
control-plane-azure.jsontoazure.jsonfor backwards compatibility.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1357
Special notes for your reviewer:
TODOs:
Release note: