Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up bazel workspace dependencies #126

Merged
merged 1 commit into from
Mar 8, 2019
Merged

clean up bazel workspace dependencies #126

merged 1 commit into from
Mar 8, 2019

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Mar 7, 2019 •
edited
Loading

This PR

i) Uses tags for the bazel dependencies.
ii) Uses the latest stable release versions for some of the dependencies.

Clean up bazel workspace to use tagged dependencies instead of commit SHAs

/priority important-longterm
/milestone baseline
/kind feature

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the baseline milestone Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2019
@tariq1890 tariq1890 requested a review from justaugustus March 7, 2019 16:00
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@tariq1890
Copy link
Contributor Author

/cc @soggiest

@k8s-ci-robot k8s-ci-robot requested a review from soggiest March 7, 2019 16:09
justaugustus
justaugustus suggested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits regarding the versions chosen.

WORKSPACE Outdated Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

Thanks @tariq1890!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ae66db into kubernetes-sigs:master Mar 8, 2019
@justaugustus justaugustus mentioned this pull request Mar 8, 2019
Closed
@tariq1890 tariq1890 deleted the bzl_workspace branch March 8, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@justaugustus justaugustus justaugustus requested changes

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@soggiest soggiest Awaiting requested review from soggiest

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
baseline
Development

Successfully merging this pull request may close these issues.
4 participants
@tariq1890 @justaugustus @k8s-ci-robot @BenTheElder