⚠️ Use custom service accounts instead of default for controllers

[furkatgofurov7]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Uses a dedicated service account for each CAPZ controller (instead of default)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1206

Special notes for your reviewer:

Please have a look thoroughly, in case I missed some important points to update in the PR. Thanks!.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

⚠️ Use custom service accounts instead of default for controllers

[k8s-ci-robot]

Hi @furkatgofurov7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[furkatgofurov7]

/cc @CecileRobertMichon @nader-ziada

[nprokopic]

Should the service account for aad-pod-identity be updated as well? https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/config/default/aad-pod-identity-deployment.yaml#L65-L67

[furkatgofurov7]

Should the service account for aad-pod-identity be updated as well? https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/config/default/aad-pod-identity-deployment.yaml#L65-L67

@nprokopic hi! Thanks for the suggestion. I was mainly following kubernetes-sigs/cluster-api/4245 and it changes only the SAs' in the system namespace, so I haven't touched it. But please do let me know if I am misunderstanding it.

[nprokopic]

I was mainly following kubernetes-sigs/cluster-api/4245 and it changes only the SAs' in the system namespace

I believe that the changes are for the default service account in multiple namespaces with names ending with -system (there is some kustomize templating involved).

Here are the default service accounts from *-system namespaces before the above linked CAPI change:

$ kubectl get serviceaccount -A | grep default | grep system
capi-kubeadm-bootstrap-system       default                              1         28d
capi-kubeadm-control-plane-system   default                              1         28d
capi-system                         default                              1         28d
capi-webhook-system                 default                              1         28d
capz-system                         default                              1         28d
kube-system                         default                              1         28d

So I believe that in CAPZ we should also update the aad-pod-identity deployment which is currently using default service account for capz-system namespace, that is of course unless aad-pod-identity doesn't have some specific requirements and it needs the default service account.

[nader-ziada]

So I believe that in CAPZ we should also update the aad-pod-identity deployment which is currently using default service account for capz-system namespace, that is of course unless aad-pod-identity doesn't have some specific requirements and it needs the default service account.

agree that aad-pod-identity service account should be updated as well

[nader-ziada]

/ok-to-test

[furkatgofurov7]

@nprokopic thanks for spotting this up, fixed it.

[furkatgofurov7]

Seems a CI flakiness, re-triggering.

/retest

[nader-ziada]

/test pull-cluster-api-provider-azure-e2e

[nprokopic]

The account that is set here I believe it should also be set in aad-pod-identity NMI DaemonSet .Spec.Template.Spec.ServiceAccountName field (in this same file), which is currently set to default.

[furkatgofurov7]

Set it to manager. PTAL.

[nader-ziada]

/lgtm

@CecileRobertMichon PTAL

[CecileRobertMichon]

should this be marked as a breaking change? I see the corresponding CAPI commit is breaking

kubernetes-sigs/cluster-api#4245

[furkatgofurov7]

@CecileRobertMichon done!

[CecileRobertMichon]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment