-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux VM and VMSS extensions #1107
Add Linux VM and VMSS extensions #1107
Conversation
74773e8
to
f95ec1f
Compare
@@ -0,0 +1,87 @@ | |||
/* | |||
Copyright 2021 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗
5f58253
to
b14ff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good in general
b14ff75
to
4fae80e
Compare
e85d580
to
9e0fad0
Compare
/retest |
9e0fad0
to
ed0de07
Compare
This is ready for another review, rebased on #1067 and fixed tests |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it: This PR adds the CAPZ Linux Bootstrapping VM extension to be used for bootstrap failure/success detection, as proposed in #1076.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Prep for #603
Special notes for your reviewer:
Currently, no script is passed into the extension so the extension is a no-op. This PR does the prep work required for #603 by adding the extension reconciler and spec. After kubernetes-sigs/cluster-api#3716 is implemented, the extension script will be modified to look for the sentinel file.
Note: the extension is only enabled for Linux in Azure Public Cloud regions for now.
TODOs:
Release note: