Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux VM and VMSS extensions #1107

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jan 7, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it: This PR adds the CAPZ Linux Bootstrapping VM extension to be used for bootstrap failure/success detection, as proposed in #1076.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Prep for #603

Special notes for your reviewer:

Currently, no script is passed into the extension so the extension is a no-op. This PR does the prep work required for #603 by adding the extension reconciler and spec. After kubernetes-sigs/cluster-api#3716 is implemented, the extension script will be modified to look for the sentinel file.

Note: the extension is only enabled for Linux in Azure Public Cloud regions for now.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add Linux VM and VMSS extensions

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jan 7, 2021
@@ -0,0 +1,87 @@
/*
Copyright 2021 The Kubernetes Authors.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecileRobertMichon CecileRobertMichon force-pushed the linux-extension branch 4 times, most recently from 5f58253 to b14ff75 Compare January 8, 2021 17:18
Copy link
Contributor

@nader-ziada nader-ziada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good in general

cloud/defaults.go Show resolved Hide resolved
cloud/services/vmssextensions/client.go Outdated Show resolved Hide resolved
cloud/services/vmssextensions/client.go Outdated Show resolved Hide resolved
cloud/services/vmssextensions/client.go Outdated Show resolved Hide resolved
cloud/services/vmssextensions/client.go Outdated Show resolved Hide resolved
cloud/services/vmssextensions/vmssextensions.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2021
@CecileRobertMichon
Copy link
Contributor Author

/retest

@CecileRobertMichon
Copy link
Contributor Author

This is ready for another review, rebased on #1067 and fixed tests

@nader-ziada
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit f133369 into kubernetes-sigs:master Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.11 milestone Jan 25, 2021
@CecileRobertMichon CecileRobertMichon deleted the linux-extension branch February 17, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants