Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove failed provisioning VM deletion logic #1049

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Remove failed provisioning VM deletion logic #1049

merged 1 commit into from
Nov 23, 2020

Conversation

Evalle
Copy link
Contributor

@Evalle Evalle commented Nov 19, 2020 •
edited by CecileRobertMichon
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the vm deletion logic.

There is a piece of code in azure machine reconciliation which deletes the VM if it's in a Failed state. The expectation is that it'll create a new VM in the next reconcile run. But with FailureReason being set before that, this will not happen and will return early in the next run.

Which issue(s) this PR fixes
Fixes #1037

Release note:

Remove failed provisioning VM deletion logic

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Evalle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 19, 2020
@Evalle
Copy link
Contributor Author

Evalle commented Nov 19, 2020

FYI @shysank @CecileRobertMichon

@devigned
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2020
CecileRobertMichon
CecileRobertMichon suggested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @Evalle. Can you please reword the commit to be more specific so it doesn't sound like we're removing all vm deletion logic? Something like Remove failed provisioning VM deletion logic.

controllers/azuremachine_controller.go Show resolved Hide resolved
@Evalle Evalle changed the title Removing the vm deletion logic Remove failed provisioning VM deletion logic Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2020
@CecileRobertMichon
Copy link
Contributor

@Evalle please squash the commits and amend the commit message to match the PR title

@Evalle
Copy link
Contributor Author

Evalle commented Nov 23, 2020

@CecileRobertMichon OK, done.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2020
CecileRobertMichon
CecileRobertMichon approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 64c6f53 into kubernetes-sigs:master Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.10 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.10
Development

Successfully merging this pull request may close these issues.

VM deleted if it is in Failed state
4 participants
@Evalle @k8s-ci-robot @devigned @CecileRobertMichon