Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update several deps #1041

Merged
merged 2 commits into from
Nov 18, 2020
Merged

dependencies: update several deps #1041

merged 2 commits into from
Nov 18, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 17, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update dependencies November cycle 😄

  • Update github.com/Azure/azure-sdk-for-go dependency to v48.2.0 which is the latest available and has the following changes
  • Update github.com/Azure/go-autorest/autorest dependency to v0.11.11 which is the latest available and has the following changes
  • Update github.com/Azure/go-autorest/autorest/azure/auth dependency to v0.5.3 which is the latest available and has the following changes
  • Update github.com/google/go-cmp dependency to v0.5.3 which is the latest available and has the following changes
  • Update github.com/hashicorp/go-retryablehttp dependency to v0.6.8 which is the latest available and has the following changes
  • Update github.com/onsi/ginkgo dependency to v1.14.2 which is the latest available and has the following changes
  • Update github.com/onsi/gomega dependency to v1.10.3 which is the latest available and has the following changes
  • Update github.com/prometheus/client_golang dependency to v1.8.0 which is the latest available and has the following changes
  • Update golang.org/x/crypto dependency to v0.0.0-20201117144127-c1f2f97bffc9
  • Update k8s.io/utils dependency to v0.0.0-20201110183641-67b214c5f920
  • Update k8s.io/api dependency to v0.17.14
  • Update k8s.io/apimachinery dependency to v0.17.14
  • Update k8s.io/client-go dependency to v0.17.14
  • Update k8s.io/component-base dependency to v0.17.14
  • Update k8s.io/kubectl dependency to v0.17.14

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

- Update `github.com/Azure/azure-sdk-for-go` dependency to `v48.2.0`
- Update `github.com/Azure/go-autorest/autorest` dependency to `v0.11.11`
- Update `github.com/Azure/go-autorest/autorest/azure/auth` dependency to `v0.5.3`
- Update `github.com/google/go-cmp` dependency to `v0.5.3`
- Update `github.com/hashicorp/go-retryablehttp` dependency to `v0.6.8`
- Update `github.com/onsi/ginkgo` dependency to `v1.14.2`
- Update `github.com/onsi/gomega` dependency to `v1.10.3`
- Update `github.com/prometheus/client_golang` dependency to `v1.8.0`
- Update `k8s.io/utils` dependency to `v0.0.0-20201110183641-67b214c5f920`
- Update `k8s.io/api` dependency to `v0.17.14`
- Update `k8s.io/apimachinery` dependency to `v0.17.14`
- Update `k8s.io/client-go` dependency to `v0.17.14`
- Update `k8s.io/component-base` dependency to `v0.17.14`
- Update `k8s.io/kubectl` dependency to `v0.17.14`

@cpanato
dependencies: update several
3dfd1e6 
- Update `github.com/Azure/azure-sdk-for-go` dependency to [v48.2.0](https://github.com/Azure/azure-sdk-for-go/tree/v48.2.0) which is the latest available and has the [following changes](https://github.com/Azure/azure-sdk-for-go/releases/tag/v48.2.0)
- Update `github.com/Azure/go-autorest/autorest` dependency to [v0.11.11](https://github.com/Azure/go-autorest/tree/autorest/v0.11.11) which is the latest available and has the [following changes](https://github.com/Azure/go-autorest/releases/tag/autorest%2Fv0.11.11)
- Update `github.com/Azure/go-autorest/autorest/azure/auth` dependency to [v0.5.3](https://github.com/Azure/go-autorest/tree/autorest/azure/auth/v0.5.3) which is the latest available and has the [following changes](https://github.com/Azure/go-autorest/releases/tag/autorest/azure/auth%2Fv0.5.3)
- Update `github.com/google/go-cmp` dependency to [v0.5.3](https://github.com/google/go-cmp/tree/v0.5.3) which is the latest available and has the [following changes](https://github.com/google/go-cmp/releases/tag/v0.5.3)
- Update `github.com/hashicorp/go-retryablehttp` dependency to [v0.6.8](https://github.com/hashicorp/go-retryablehttp/tree/v0.6.8) which is the latest available and has the [following changes](https://github.com/hashicorp/go-retryablehttp/releases/tag/v0.6.8)
- Update `github.com/onsi/ginkgo` dependency to [v1.14.2](https://github.com/onsi/ginkgo/tree/v1.14.2) which is the latest available and has the [following changes](https://github.com/onsi/ginkgo/releases/tag/v1.14.2)
- Update `github.com/onsi/gomega` dependency to [v1.10.3](https://github.com/onsi/gomega/tree/v1.10.3) which is the latest available and has the [following changes](https://github.com/onsi/gomega/releases/tag/v1.10.3)
- Update `github.com/prometheus/client_golang` dependency to [v1.8.0](https://github.com/prometheus/client_golang/tree/v1.8.0) which is the latest available and has the [following changes](https://github.com/prometheus/client_golang/releases/tag/v1.8.0)
- Update `golang.org/x/crypto` dependency to `v0.0.0-20201117144127-c1f2f97bffc9`
- Update `k8s.io/utils` dependency to `v0.0.0-20201110183641-67b214c5f920`
- Update `k8s.io/api` dependency to `v0.17.14`
- Update `k8s.io/apimachinery` dependency to `v0.17.14`
- Update `k8s.io/client-go` dependency to `v0.17.14`
- Update `k8s.io/component-base` dependency to `v0.17.14`
- Update `k8s.io/kubectl` dependency to `v0.17.14`
@cpanato
dependencies: update imports due to deps upgrade
4e9c0d8
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Nov 17, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2020
@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

waiting for the E2E to complete to trigger the conformance and other tests

cpanato
cpanato commented Nov 17, 2020
View reviewed changes
go.mod
k8s.io/client-go v0.17.12
k8s.io/component-base v0.17.12
golang.org/x/crypto v0.0.0-20201117144127-c1f2f97bffc9
k8s.io/api v0.17.14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we upgrade this to 0.18.x ? or we need to stay on 1.17 for any reason that i don't know :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.17 is fine for now, let's stick to the same minor version as CAPI 0.3 https://github.com/kubernetes-sigs/cluster-api/blob/release-0.3/go.mod#L35

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, we should stay on 1.17 until we jump to 1.19 following CAPI (https://github.com/kubernetes-sigs/cluster-api/blob/e6b0039b4aa1021b0a9afec8a527d969c20acabb/go.mod#L32)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarification @devigned @CecileRobertMichon

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

/assign @CecileRobertMichon @nader-ziada @devigned

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020 •
edited
Loading

test Timed out after 1200.000s.
just one test failed

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

/test pull-cluster-api-provider-azure-e2e

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-full
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-verify
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-coverage

Use /test all to run the following jobs:

  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-coverage

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Nov 17, 2020

/test pull-cluster-api-provider-azure-conformance-v1alpha3
/test pull-cluster-api-provider-azure-e2e-full

CecileRobertMichon
CecileRobertMichon reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2020
@cpanato
Copy link
Member Author

cpanato commented Nov 18, 2020

/test pull-cluster-api-provider-azure-e2e-full

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@devigned
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,devigned]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devigned
Copy link
Contributor

/retest

@devigned
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0477320 into kubernetes-sigs:master Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.10 milestone Nov 18, 2020
@cpanato cpanato deleted the update-deps branch November 19, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@devigned devigned devigned left review comments

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@devigned devigned

@nader-ziada nader-ziada

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.10
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @CecileRobertMichon @devigned @nader-ziada