Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if experimentalRetryJoin still needed for K8s 1.19+ #998

Closed
jsturtevant opened this issue Oct 14, 2020 · 1 comment · Fixed by #1029
Closed

Test if experimentalRetryJoin still needed for K8s 1.19+ #998

jsturtevant opened this issue Oct 14, 2020 · 1 comment · Fixed by #1029
Assignees
@nader-ziada
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.5.0

Comments

@jsturtevant
Copy link
Contributor

/kind feature

Describe the solution you'd like
In 1.19+ retry support was added to kubeadm: https://kubernetes.slack.com/archives/C8TSNPY4T/p1601486982126900. We should test 1.19 to see if the useExperimentalRetryJoin is still required as was added for #832 and #833.

Anything else you would like to add:
This is related to kubernetes-sigs/cluster-api-provider-aws#1993 and Window support kubernetes-sigs/cluster-api#3616 (comment)

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version): 1.19+
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 14, 2020
@jsturtevant jsturtevant mentioned this issue Oct 14, 2020
Merged
@CecileRobertMichon CecileRobertMichon added this to the v0.4.10 milestone Oct 15, 2020
@CecileRobertMichon CecileRobertMichon mentioned this issue Oct 26, 2020
Merged
3 tasks
@nader-ziada
Copy link
Contributor

/assign

@nader-ziada nader-ziada mentioned this issue Nov 10, 2020
Merged
3 tasks
@CecileRobertMichon CecileRobertMichon modified the milestones: v0.4.10, v0.4.11 Nov 12, 2020
@CecileRobertMichon CecileRobertMichon modified the milestones: v0.4.11, v0.5.x Jan 21, 2021
@CecileRobertMichon CecileRobertMichon modified the milestones: v0.5.x, v0.5.0 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nader-ziada nader-ziada

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Don't useExperimentalRetryJoin nader-ziada/cluster-api-provider-azure
4 participants
@jsturtevant @nader-ziada @CecileRobertMichon @k8s-ci-robot