Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version for managed control plane should be normalized in webhook #836

Closed
alexeldeib opened this issue Jul 28, 2020 · 3 comments · Fixed by #906
Closed

version for managed control plane should be normalized in webhook #836

alexeldeib opened this issue Jul 28, 2020 · 3 comments · Fixed by #906
Assignees
@cpanato
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.4.9

Comments

@alexeldeib
Copy link
Contributor

/kind feature

Describe the solution you'd like

AzureManagedControlPlane should have the version normalized to handle kubernetes-sigs/cluster-api#3147.

We should add a defaulting webhook similar to machine to handle the normalization: https://github.com/CecileRobertMichon/cluster-api/blob/9aaae9f9b5152ed4dc8ce8f2fe6e51f8c6395a37/api/v1alpha3/machine_webhook.go#L60-L63

Anything else you would like to add:

We need to do something similar for MachinePool, but upstream in CAPI.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 28, 2020
@alexeldeib
Copy link
Contributor Author

ref #818 which is the current implementation of the same thing, but we should put this in a webhook

@alexeldeib alexeldeib changed the title version for managed control plane should be normalized version for managed control plane should be normalized in webhook Jul 29, 2020
@CecileRobertMichon CecileRobertMichon added this to the next milestone Aug 4, 2020
@CecileRobertMichon
Copy link
Contributor

/help
/good-first-issue

webhook for managed control plane was added in #862

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 20, 2020
@cpanato
Copy link
Member

cpanato commented Aug 28, 2020

will take this
/assign
/remove-help

@k8s-ci-robot k8s-ci-robot removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 28, 2020
@cpanato cpanato mentioned this issue Aug 28, 2020
Merged
3 tasks
@nader-ziada nader-ziada modified the milestones: next, v0.4.9 Sep 3, 2020
k8s-ci-robot added a commit that referenced this issue Sep 9, 2020
@k8s-ci-robot
Merge pull request #906 from cpanato/GH-836
fe6ada8 
🌱 AzureManagedControlPlane: validate version in azure manager controlplane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpanato cpanato

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.4.9
5 participants
@cpanato @alexeldeib @nader-ziada @CecileRobertMichon @k8s-ci-robot