-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default branch to "main" #749
Comments
@vincepri: You must be a member of the kubernetes-sigs/cluster-api-provider-azure-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider Azure Maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/lifecycle frozen |
this is a guide with the required steps: https://www.kubernetes.dev/resources/rename/ It is recommended to do with when is a small number of PRs since all the prow jobs will be re-triggered for active PRs |
/assign |
Added checklist in issue description above. I will start making the changes in "anytime". |
@mboersma would you be able to take the "just before rename" steps? |
@CecileRobertMichon sure, I'll get on that now. |
@nader-ziada @devigned @alexeldeib @shysank FYI planning on doing the rename tomorrow around 11 am (PT) All contributors will need to follow these instructions for renaming their local branch. |
@mboersma we also need to change the CAPI quickstart instructions for installing Calico after the branch has been renamed https://cluster-api.sigs.k8s.io/user/quick-start.html#deploy-a-cni-solution |
another one: we need to change any GitHub action referring to "master" to use "main" I'll take this |
Yes, I hadn't pounced on that yet since it's a post-rename activity, but I'll make a docs change PR now. |
/close The switch to |
@mboersma: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Once the community agrees on the naming, we need to change our default development branch to
main
, and check that any tools or references to it are changed as well.This includes the container image tag used in development.
/kind cleanup
/wg naming
/milestone Next
Steps:
Prerequisites
Create an issue in your repo to track the branch rename.
You can paste this checklist in the issue body.
If you are not a root approver for the repo, assign a root
approver for approval.
Once the issue has been approved, send a notice to your SIG's
mailing list about the potential branch rename.
Changes pre-rename
Make the following changes before renaming the branch the
master
branch.Note: There might be additional changes required that have not been
covered in this checklist.
Anytime
These changes are non-disruptive and can be made anytime before renaming
the branch.
If a presubmit or postsubmit prowjob triggers on the
master
branch(
branches
field of the prowjob), add themain
branch to the list(see [prep kubernetes/org jobs for default branch rename kubernetes/test-infra#20665] for an example).
If the [
milestone_applier
] prow config references themaster
branch,add the
main
branch to the config (see [Prep kubernetes/k8s.io for default branch rename kubernetes/test-infra#20675] for an example).If the [
branch_protection
] prow config references themaster
branch,add the
main
branch to the config.Just before rename
These changes are disruptive and should be made just before renaming the
branch.
For periodic prowjobs, or any prowjob that mentions the
master
branchin
base_ref
, update them to themain
branch. Ensure that these changeshappen in lock-step with the branch rename (jobs triggered in between landing
these changes and renaming the branch will fail).
e.g.
kubernetes/foo=main
. [Allow pod-utils / clonerefs to use default remote branch kubernetes/test-infra#20667] may eventuallyallow for non-disruptive changes.
e.g.
base_ref: main
. [Allow bootstrap to use default remote branch kubernetes/test-infra#20672] may eventually allowfor non-disruptive changes.
If a prowjob mentions
master
in its name, rename the job to not includethe branch name, e.g.
pull-repo-verify-master
->pull-repo-verify
.[
status-reconciler
] should automatically migrate PR status contexts to thenew job name, and retrigger accordingly, but we have anecdotally found it
sometimes misses changes.
from the perspective of e.g. https://testgrid.k8s.io the job will appear to
have lost history and start from scratch.
If a prowjob calls scripts or code in your repo that explicitly
reference
master
, update all references to usemain
, or auto-detect theremote branch
If the repo has netlify configured for it, ask a member of the GitHub
Management Team to rename the
master
branch tomain
in the netlify site config.It can't be controlled through the netlify config in the repo.
Approval
have been identified, assign the GitHub Management team ([@kubernetes/owners])
for approval.
Rename the default branch
master
tomain
using the GitHub UIby following the [official instructions].
Changes post-rename
After the default branch has been renamed to
main
, make the followingchanges.
Note: There might be additional changes required that have not been
covered in this checklist.
Prowjobs
master
branch in thebranches
field,remove the
master
branch (see [Update kubernetes/org job configs post default-branch-rename kubernetes/test-infra#20669] for an example).Prow config
If the [
milestone_applier
] prow config references themaster
branch,remove it from the config.
If the [
branch_protection
] prow config references themaster
branch,remove it from the config.
Other
If any docs reference the
master
branch, update tomain
(URLs will be automatically redirected).
Ensure that CI and PR tests work fine.
that presubmits and postsubmits work as expected
Trial the local development experience with a pre-rename clone.
have git autocompletion enabled, typing
ma<tab>
will autocomplete tomain
Send a notice about the branch rename to your SIG's mailing list.
Include the link to the [GitHub instructions to rename your local branch].
The text was updated successfully, but these errors were encountered: