Worker nodes (MachinePool) deployed to control plane subnet

[nprokopic]

/kind bug

What steps did you take and what happened:

I deployed a cluster with machine pools and virtual machine scale set with worker nodes was deployed to control plane subnet $cluster_name-vnet/$cluster_name-controlplane-subnet.

What did you expect to happen:

Virtual machine scale set with worker nodes should be deployed to node subnet $cluster_name-vnet/$cluster_name-node-subnet.

Environment:

• cluster-api-provider-azure version: v0.4.4

• Kubernetes version:

KIND management cluster:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.8", GitCommit:"ec6eb119b81be488b030e849b9e64fda4caaf33c", GitTreeState:"clean", BuildDate:"2020-03-12T21:00:06Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-30T20:19:45Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Deployed workload cluster:

$ kubectl --kubeconfig="${kubeconfig_path}" version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.8", GitCommit:"ec6eb119b81be488b030e849b9e64fda4caaf33c", GitTreeState:"clean", BuildDate:"2020-03-12T21:00:06Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

• OS (e.g. from /etc/os-release):

$ cat /etc/os-release 
NAME="KDE neon"
VERSION="5.19"
ID=neon
ID_LIKE="ubuntu debian"
PRETTY_NAME="KDE neon User Edition 5.19"
VARIANT="User Edition"
VERSION_ID="18.04"
HOME_URL="http://neon.kde.org/"
SUPPORT_URL="http://neon.kde.org/"
BUG_REPORT_URL="http://bugs.kde.org/"
LOGO=start-here-kde-neon
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

[nprokopic]

@CecileRobertMichon gave me a hint that the issue is probably caused by this line here https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/exp/controllers/azuremachinepool_controller.go#L491.

Didn't have time to look into it over the weekend (first need to setup CAPZ dev environment), I'll try to get into it this week.

[CecileRobertMichon]

/good-first-issue
/assign nprokopic

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/assign nprokopic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.