Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatcar support for CAPZ #629

Closed
rbitia opened this issue May 18, 2020 · 30 comments
Closed

Flatcar support for CAPZ #629

rbitia opened this issue May 18, 2020 · 30 comments
Assignees
@invidian
Labels
kind/feature Categorizes issue or PR as related to a new feature. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc)

Comments

@rbitia
Copy link
Contributor

rbitia commented May 18, 2020

/kind feature

Describe the solution you'd like
Support users that have a dependency on CoreOS by supporting Flatcar containers in CAPZ.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2020
@detiber
Copy link
Member

detiber commented May 18, 2020

I suspect this will need additional support from the kubeadm bootstrap provider and image-builder support as well (kubernetes-sigs/cluster-api#1582), since Flatcar is managed quite a bit differently than the currently supported OSs.

@CecileRobertMichon CecileRobertMichon added this to the next milestone Jun 4, 2020
@CecileRobertMichon CecileRobertMichon added the parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc) label Jun 4, 2020
@CecileRobertMichon
Copy link
Contributor

kubernetes-sigs/image-builder#248

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2020
@CecileRobertMichon
Copy link
Contributor

I'm going to close this one since it doesn't require any changes to the infra provider AFAIK and it's already being tackled from an image perspective in kubernetes-sigs/image-builder#248 and for bootstrapping in kubernetes-sigs/cluster-api#3437

/close

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

I'm going to close this one since it doesn't require any changes to the infra provider AFAIK and it's already being tackled from an image perspective in kubernetes-sigs/image-builder#248 and for bootstrapping in kubernetes-sigs/cluster-api#3437

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbatts
Copy link

vbatts commented Sep 17, 2020

@CecileRobertMichon I think it may require infra-provider updates, it just that the image-builder work has been a huge thing for review and feedback.

@vbatts
Copy link

vbatts commented Sep 17, 2020

I guess I was mis-remembering. Looking through the code it doesn't seem to have particular things jump out as blockers. There is a good chance we need a change to incorporate the ignition-bootstrap-provider, rather than just kubeadm-bootstrap-provider.
The big this is for us to work through the providers and get testing on this.

@CecileRobertMichon
Copy link
Contributor

reopening to track testing / integration

/remove-lifecycle rotten
/reopen

@k8s-ci-robot k8s-ci-robot reopened this Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Reopened this issue.

In response to this:

reopening to track testing / integration

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2020
@vbatts
Copy link

vbatts commented Dec 7, 2020

@CecileRobertMichon nice. This is on our roadmap and I'm looking forward to making it happen.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2021
@vbatts
Copy link

vbatts commented Mar 7, 2021

cc @invidian

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2021
@invidian
Copy link
Member

invidian commented Apr 6, 2021

/remove-lifecycle rotten

Small update. We've got image-builder to build CAPI Azure images, but there is still some thing which needs to be resolved before we open the PR.

Changes proposed in kubernetes-sigs/cluster-api#4172 works out of the box with CAPZ, except new cluster configuration template needs to be submitted including some minor differences in node configuration. Mentioned here: kubernetes-sigs/cluster-api#4172 (comment).

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 6, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2021
@devigned
Copy link
Contributor

devigned commented Oct 3, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2021
@invidian
Copy link
Member

invidian commented Dec 9, 2021

CABPK PR kubernetes-sigs/cluster-api#4172 has been merged and will be part of v1.1 release, so we're getting closer getting this resolved 🎉

@AverageMarcus AverageMarcus mentioned this issue Feb 23, 2022
Open
@CecileRobertMichon CecileRobertMichon modified the milestones: next, v1.3 Mar 1, 2022
@CecileRobertMichon
Copy link
Contributor

/assign @invidian

@CecileRobertMichon CecileRobertMichon modified the milestones: v1.3, v1.4 May 4, 2022
@CecileRobertMichon CecileRobertMichon modified the milestones: v1.4, v1.5 Jul 7, 2022
@mboersma
Copy link
Contributor

@invidian is this still ongoing? We have it tagged for the next release, but can change that if it's not going to land.

@invidian
Copy link
Member

Thanks for the ping @mboersma. I'll try to push things forward again, as we're only missing some final conversation around flatcar/Flatcar#734. Hopefully this could happen by the end of this month, but please don't wait for this with the release.

@jackfrancis
Copy link
Contributor

@invidian should we consider the progress of flatcar + capz blocked on flatcar/Flatcar#734 ?

@jackfrancis jackfrancis modified the milestones: v1.5, next Sep 1, 2022
@invidian
Copy link
Member

invidian commented Sep 1, 2022

@invidian should we consider the progress of flatcar + capz blocked on flatcar/Flatcar#734 ?

Definitely.

@Rotfuks Rotfuks mentioned this issue Nov 23, 2022
Closed
50 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 30, 2022
@invidian
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 30, 2022
@invidian invidian mentioned this issue Dec 1, 2022
Merged
3 tasks
@invidian
Copy link
Member

invidian commented Dec 2, 2022

It's almost done in #2890.

@invidian
Copy link
Member

/close

#2890 is now merged.

@k8s-ci-robot
Copy link
Contributor

@invidian: Closing this issue.

In response to this:

/close

#2890 is now merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon CecileRobertMichon removed this from the next milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@invidian invidian

Labels
kind/feature Categorizes issue or PR as related to a new feature. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests