Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use host based time sync instead of systemd-timesyncd by default #539

Closed
CecileRobertMichon opened this issue Apr 16, 2020 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Apr 16, 2020

Follow up from #535, we should look into replacing systemd-timesyncd time sync with host based.

References:
https://help.ubuntu.com/lts/serverguide/NTP.html
https://docs.microsoft.com/en-us/azure/virtual-machines/linux/time-sync
Azure/aks-engine#2552

We can also consider enabling chrony.

These changes will most likely live in the image-builder but tracking here since the image would be consumed by capz.

@CecileRobertMichon
Copy link
Contributor Author

from @ericsuhong's comment in the aks-engine issue above, "I found out that disabling NTP is not enough for enabling host-only sync mode. If you disable NTP, VMs till only sync from host on when VM is paused or reboot (got a confirmation from Azure Linux team). Chrony is the only way to sync time from host using PTP source."

@CecileRobertMichon CecileRobertMichon added this to the next milestone Apr 17, 2020
@CecileRobertMichon CecileRobertMichon added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2020
@randomvariable
Copy link
Member

randomvariable commented Apr 22, 2020

Maybe for most complete coverage, and this would also cover vSphere environments where PTP might be enabled. Needs some testing as I don't know if ptp4l works without PTP packets arriving on a network interface:

@randomvariable
Copy link
Member

Chatting @nader-ziada , I hadn't realised Ubuntu switched to chrony in 18.04, so I think we're good to go with chrony for the major distros.

@nader-ziada
Copy link
Contributor

/assign

@nader-ziada
Copy link
Contributor

created PR in image builder repo kubernetes-sigs/image-builder#240

@nader-ziada
Copy link
Contributor

PR in image-builder repo merged

@ericsuhong
Copy link

@nader-ziada Does this change mean that all default 18.04 Azure Ubuntu VMs will come with chrony enabled by default? I am wondering what would it take for us to start using this feature.

@nader-ziada
Copy link
Contributor

yes, the capi 18.04 Azure Ubuntu VM will come with chrony enabled by default, but I believe we have not yet published such an image to the Azure Marketplace

@nader-ziada
Copy link
Contributor

the linked PR ads chrony to the image, closing this

/close

@k8s-ci-robot
Copy link
Contributor

@nader-ziada: Closing this issue.

In response to this:

the linked PR ads chrony to the image, closing this

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon CecileRobertMichon removed this from the next milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants