Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old comment and log line from zone_reconciler.go #3819

Closed
1 task
mboersma opened this issue Aug 9, 2023 · 4 comments · Fixed by #3827
Closed
1 task

Remove old comment and log line from zone_reconciler.go #3819

mboersma opened this issue Aug 9, 2023 · 4 comments · Fixed by #3827
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mboersma
Copy link
Contributor

mboersma commented Aug 9, 2023

/kind cleanup

What needs cleanup:

A comment in zone_reconciler.go of the privatedns service mentions that a log line should be removed after some time, since it's just there to notify users of a workaround that is no longer needed.

Describe the solution you'd like

Read the comment and the PR it references and verify that it should now be safe to remove this log line. Then remove the comment and log line following it.

Files to change: 1

  • zone_reconciler.go
    • // TODO: Remove this log in future release. This is only required because older clusters created before https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1791 will not have capz ownership tags.
      log.V(1).Info("Tag the DNS manually from azure to manage it with capz."+
      "Please see https://capz.sigs.k8s.io/topics/custom-dns.html#manage-dns-via-capz-tool", "private DNS", zoneSpec.ResourceName())
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 9, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Aug 9, 2023

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mboersma:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 9, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Aug 10, 2023

/assign @Tea4menono

See #3827

@k8s-ci-robot
Copy link
Contributor

@mboersma: GitHub didn't allow me to assign the following users: Tea4menono.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Tea4menono

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants