Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reconcile-policy: skip on ASO resources when Cluster is paused #3525

Closed
1 task done
Tracked by #3527 ...
nojnhuh opened this issue May 4, 2023 · 3 comments
Closed
1 task done
Tracked by #3527 ...

Set reconcile-policy: skip on ASO resources when Cluster is paused #3525

nojnhuh opened this issue May 4, 2023 · 3 comments
Assignees
Milestone

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented May 4, 2023

Since a Cluster's spec.paused indicates whether reconciliation is disallowed, CAPZ should communicate that intent with ASO so all reconciliation stops when spec.paused is true. Likewise, when a Cluster is unpaused, reset the reconcile-policy annotation to its previous value (reconcile-policy may have already been skip even before the Cluster was paused if the corresponding Azure resource is managed by the user).

Dependencies

Preview Give feedback
  1. area/api area/clusterctl kind/feature triage/accepted
    nojnhuh

Note: Since annotating all ASO resources is not an instantaneous operation, CAPZ may be able to perform a best-effort "pause reconciliation of as many ASO resources as possible" even without the above dependency, but it might turn into a bit of a minefield for flakes in tests involving clusterctl move.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 19, 2023

/assign

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 14, 2023

Note: Since annotating all ASO resources is not an instantaneous operation, CAPZ may be able to perform a best-effort "pause reconciliation of as many ASO resources as possible" even without the above dependency, but it might turn into a bit of a minefield for flakes in tests involving clusterctl move.

This is the strategy for now as a result of the tests done in #3795. #3839 will fill the gap down the road. Otherwise the work for this issue is complete.

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closing this issue.

In response to this:

Note: Since annotating all ASO resources is not an instantaneous operation, CAPZ may be able to perform a best-effort "pause reconciliation of as many ASO resources as possible" even without the above dependency, but it might turn into a bit of a minefield for flakes in tests involving clusterctl move.

This is the strategy for now as a result of the tests done in #3795. #3839 will fill the gap down the road. Otherwise the work for this issue is complete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants