Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing and metrics - Open Telemetry #311

Closed
rbitia opened this issue Oct 22, 2019 · 17 comments · Fixed by #1019
Closed

Add tracing and metrics - Open Telemetry #311

rbitia opened this issue Oct 22, 2019 · 17 comments · Fixed by #1019
Assignees
@devigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4.10

Comments

@rbitia
Copy link
Contributor

rbitia commented Oct 22, 2019 •
edited
Loading

/kind feature
Add tracing and metrics with Open Telemetry so CAPZ is observable.
Logging cluster provisioning metrics which will eventually export to Azure monitor.

cc. @devigned
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2019
@justaugustus
Copy link
Contributor

I think this should be a wider Cluster API discussion as opposed to a capz one.
Thoughts @vincepri @ncdc @detiber?

/priority important-longterm
/milestone next

@k8s-ci-robot k8s-ci-robot added this to the next milestone Oct 24, 2019
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 24, 2019
@ncdc
Copy link
Contributor

ncdc commented Oct 24, 2019

We have a CAPI issue: kubernetes-sigs/cluster-api#1477. Maybe rally discussion there?

@vincepri
Copy link
Member

vincepri commented Oct 24, 2019 •
edited
Loading

There is lots of context in the CAPI issue that @ncdc linked. If folks here want to start on implementing metrics now and bring back the findings, that sounds good to me.

Each manager will have to implement and expose metrics anyways :)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2020
@rbitia
Copy link
Contributor Author

rbitia commented Feb 20, 2020

@devigned do you have some time to split this issue out into size-able chunks? Feel free to open new issues or list them out here.

@devigned
Copy link
Contributor

Will do.

@devigned
Copy link
Contributor

/assign

@rbitia
Copy link
Contributor Author

rbitia commented Mar 20, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2020
@devigned
Copy link
Contributor

Things to collect?

  • Success / failure of Azure Resource (possibly available from Azure SDK for Go metrics)
    • AzureCluster
      • resource group
      • route table
      • network security group
      • vnet
      • subnet
        -load balancer (internal / external)
    • AzureMachine
      • virtual machine
      • network interface
      • public IP
      • disk
      • availability zone
  • Machines / Cluster / State
    • research into labels or other ways to slice data
  • Duration of deployment
  • Time since last reconcile for a given AzureMachine / AzureCluster
  • Duration of reconcile

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 8, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devigned
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 13, 2020
@devigned
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@devigned: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 13, 2020
@devigned
Copy link
Contributor

/milestone v0.4.10

@k8s-ci-robot k8s-ci-robot modified the milestones: next, v0.4.10 Oct 13, 2020
@devigned devigned mentioned this issue Oct 30, 2020
Merged
3 tasks
@richardcase richardcase mentioned this issue Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devigned devigned

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4.10
Development

Successfully merging a pull request may close this issue.

instrument tracing and add metrics for Azure SDK requests devigned/cluster-api-provider-azure
7 participants
@ncdc @devigned @justaugustus @vincepri @rbitia @k8s-ci-robot @fejta-bot