Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async scalesets refactor #2719

Closed
Tracked by #1702
CecileRobertMichon opened this issue Oct 11, 2022 · 4 comments · Fixed by #3111
Closed
Tracked by #1702

async scalesets refactor #2719

CecileRobertMichon opened this issue Oct 11, 2022 · 4 comments · Fixed by #3111
Assignees
@Jont828
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.11

Comments

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Oct 11, 2022 •
edited
Loading

We should refactor the scaleset service to reuse the async.go framework instead of using its own implementation.

This might need to wait until #999 is done first so it doesn't interfere.
@CecileRobertMichon CecileRobertMichon mentioned this issue Oct 11, 2022
Closed
23 tasks
@CecileRobertMichon CecileRobertMichon changed the title async scalesets async scalesets refactor Oct 11, 2022
@CecileRobertMichon
Copy link
Contributor Author

/cc @mboersma

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@mboersma
Copy link
Contributor

mboersma commented Jan 9, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@Jont828
Copy link
Contributor

Jont828 commented Jan 27, 2023

/assign

@Jont828 Jont828 mentioned this issue Jan 27, 2023
Merged
3 tasks
@CecileRobertMichon CecileRobertMichon mentioned this issue Mar 21, 2023
Closed
@dtzar dtzar added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 5, 2023
@Jont828 Jont828 added this to the v1.10 milestone Jun 15, 2023
@CecileRobertMichon CecileRobertMichon modified the milestones: v1.10, next Jul 6, 2023
@mboersma mboersma modified the milestones: next, v1.11 Jul 13, 2023
@CecileRobertMichon CecileRobertMichon mentioned this issue Jul 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jont828 Jont828

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

Make scaleset reconcile/delete async Jont828/cluster-api-provider-azure
6 participants
@mboersma @dtzar @CecileRobertMichon @Jont828 @k8s-ci-robot @k8s-triage-robot