Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDCIssuerProfile configuration option #2498

Closed
Tracked by #3446
nijave opened this issue Jul 22, 2022 · 12 comments · Fixed by #3973
Closed
Tracked by #3446

Add OIDCIssuerProfile configuration option #2498

nijave opened this issue Jul 22, 2022 · 12 comments · Fixed by #3973
Assignees
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@nijave
Copy link

nijave commented Jul 22, 2022

/kind feature

Describe the solution you'd like
In order to enable Azure Workload Identity, the OIDC issuer needs to be enabled on new clusters. Add a field AzureManagedControlPlane for enabling OIDC issuer.

Anything else you would like to add:
Basically just a configuration option that does the same as this cli command https://docs.microsoft.com/en-us/azure/aks/cluster-configuration#update-an-aks-cluster-with-oidc-issuer

Environment:

  • cluster-api-provider-azure version: v1.4.0
  • Kubernetes version: (use kubectl version): v1.22
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 22, 2022
@CecileRobertMichon
Copy link
Contributor

/help

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 22, 2022
@CecileRobertMichon
Copy link
Contributor

/area managedclusters

@k8s-ci-robot k8s-ci-robot added the area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type label Jul 22, 2022
@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 1, 2022

/assign

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 2, 2022

Since we haven't added any AKS preview features yet to CAPZ, there's some work we need to do yet to determine how those should be implemented generally which is being tracked in #2625. Once that's done, this looks like it would be a great first preview feature to implement!

/unassign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@nijave
Copy link
Author

nijave commented Feb 8, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@mjnovice
Copy link
Contributor

+1 for this feature.

@andreipantelimon
Copy link

andreipantelimon commented Jul 25, 2023

Workload Identity is now Merged in CAPZ and GA in Azure and since AAD Pod Identity is getting deprecated, this feature is mandatory. Is there a guide on how to enable this?

@CecileRobertMichon
Copy link
Contributor

@mboersma @nojnhuh this is one where we need either ASO (#3529) or SDK v2 (#3409) to be able to unblock it

@maciaszczykm
Copy link
Member

I'd really love to have it. Do you have any estimate on when it should be ready? Even on main branch.

@dtzar dtzar added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 6, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 7, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants